From owner-svn-ports-head@freebsd.org Sat Nov 26 01:17:32 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3C279C5306D for ; Sat, 26 Nov 2016 01:17:32 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: from asp.reflexion.net (outbound-mail-210-32.reflexion.net [208.70.210.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E41B8E9B for ; Sat, 26 Nov 2016 01:17:31 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: (qmail 24531 invoked from network); 26 Nov 2016 01:17:10 -0000 Received: from unknown (HELO rtc-sm-01.app.dca.reflexion.local) (10.81.150.1) by 0 (rfx-qmail) with SMTP; 26 Nov 2016 01:17:10 -0000 Received: by rtc-sm-01.app.dca.reflexion.local (Reflexion email security v8.20.0) with SMTP; Fri, 25 Nov 2016 20:17:10 -0500 (EST) Received: (qmail 21213 invoked from network); 26 Nov 2016 01:17:10 -0000 Received: from unknown (HELO iron2.pdx.net) (69.64.224.71) by 0 (rfx-qmail) with (AES256-SHA encrypted) SMTP; 26 Nov 2016 01:17:10 -0000 Received: from [192.168.1.106] (c-76-115-7-162.hsd1.or.comcast.net [76.115.7.162]) by iron2.pdx.net (Postfix) with ESMTPSA id E7E67EC7977; Fri, 25 Nov 2016 17:17:24 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.1 \(3251\)) Subject: Re: svn commit: r427110 - head/lang/gcc/files [does lang/gcc49 need such too?] From: Mark Millard In-Reply-To: <9D54F0CC-F38C-4CCE-BC33-25C1457BD44B@FreeBSD.org> Date: Fri, 25 Nov 2016 17:17:24 -0800 Cc: svn-ports-head@freebsd.org, FreeBSD Ports , Gerald Pfeifer Content-Transfer-Encoding: 7bit Message-Id: <5C936BA8-6941-431A-B05F-31030816F85C@dsl-only.net> References: <86C72DB2-B9ED-4512-A88C-BD1D9A23806F@dsl-only.net> <9D54F0CC-F38C-4CCE-BC33-25C1457BD44B@FreeBSD.org> To: Dimitry Andric X-Mailer: Apple Mail (2.3251) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Nov 2016 01:17:32 -0000 On 2016-Nov-25, at 5:00 PM, Dimitry Andric wrote: > On 26 Nov 2016, at 01:13, Mark Millard wrote: >> >>> Author: dim (src committer) >>> Date: Fri Nov 25 12:54:01 2016 >>> New Revision: 427110 >>> URL: >>> https://svnweb.freebsd.org/changeset/ports/427110 >>> >>> >>> Log: >>> Fix build of lang/gcc with libc++ 3.9.0, similar to r421625: >>> . . . >>> What is happening here, is that the source file includes gcc/system.h, >>> which defines abort to fancy_abort, and then the source file includes >>> , which attempts to call _VSTD::abort() (the _VSTD is a libc++ >>> alias for std::). The macro definition then causes the above breakage. >>> >>> Newer gcc ports, such as gcc5 and gcc6 don't show this issue, because >>> upstream gcc first added an include of (which indirectly >>> includes ) in r217348 [1], and later even add a direct include of >>> in r232736 [2]. >>> >>> Fix it for this version, by adding the direct include of to >>> gcc/system.h. This makes the 'second' includes of in some .c >>> files superfluous, but at least they won't result in errors. >> >> Will lang/gcc49 needs similar changes? > > Actually, the patch was copied from the lang/gcc49 port, which had > already been fixed earlier, in r421625. Good to know. >> (I normally only use explicitly version numbered lang/gcc* 's and >> I use lang/gcc49 on powerpc64's.) > > Well, lang/gcc is a special case, in the sense that some ports that have > USE_GCC=yes, e.g. with an unspecified version, will default to it. I wonder if that leaves lang/gcc and lang/gcc49 as conflicting. But luckily so far I've not picked to build anything that built lang/gcc. Or, more likely(?), if some gcc is already installed it is used instead if lang/gcc is not installed yet. I tend to install an explicit (not older) lang/gcc* first, before building much else. [Another example of conflicts can be powerpc64-gcc vs. a sometimes matching version of devel/gcc* in the same powerpc64 environment. For my activity I give priority to powerpc64-gcc despite it needing a workaround to finish installing it in a powerpc64 environment.] > -Dimitry Thanks for all the projects/clang390-import work and powerpc64 and powerpc back-porting to 3.9.0. Now I've got some testing/exploring to do in powerpc64 and powerpc lands. === Mark Millard markmi at dsl-only.net