From owner-freebsd-ports@FreeBSD.ORG  Wed Jul 13 15:41:52 2011
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id D3DB11065672;
	Wed, 13 Jul 2011 15:41:51 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: Pav Lucistnik <pav@freebsd.org>
Date: Wed, 13 Jul 2011 11:41:37 -0400
User-Agent: KMail/1.6.2
References: <201107121826.00020.jkim@FreeBSD.org>
	<4E1D8408.1080609@FreeBSD.org>
In-Reply-To: <4E1D8408.1080609@FreeBSD.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201107131141.43840.jkim@FreeBSD.org>
Cc: Stephen Montgomery-Smith <stephen@freebsd.org>, freebsd-ports@freebsd.org
Subject: Re: [RFC] A trivial change for DESKTOP_ENTRIES
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Jul 2011 15:41:52 -0000

On Wednesday 13 July 2011 07:39 am, Pav Lucistnik wrote:
> On 2011/07/13 00:25, Jung-uk Kim wrote:
> > After I updated x11-wm/compiz, GNOME was not able to start the
> > window manager.  Basically, it complained that compiz-manager was
> > not found. Then, I realized compiz-manager.desktop was
> > automagically replaced by compizmanager.desktop.  Now I tracked
> > it down to this commit:
> >
> > Sat Nov 27 17:42:46 2010 UTC (7 months, 2 weeks ago) by pav
> >
> > - DESKTOP_ENTRIES: commandline is used to name installed .desktop
> > file, this can lead to files containing whitespace and funny
> > characters; thus strip all non-alphanumeric characters
> >
> > http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.port.mk.diff?r
> >1=1.656;r2=1.657
> >
> > To me, it looks far too restrictive.  At least, I'd like to allow
> > '-' and '_'.  Please see the attached patch.
> >
> > Any objections?
>
> Shouldn't you fix whatever is trying to call compizmanager not to
> use .desktop file instead?

GNOME session manager calls the compiz-manager, i.e., the user has to 
change it manually.  Actually, x11-wm/compiz/pkg-message recommended 
this:

"If you are using gnome, you can use the configuration editor to set 
the value of:

desktop->gnome->session->required_components->windowmanager = 
compiz-manager
^^^^^^^^^^^^^^

This will enable compiz as your default window manager."

I am quite sure there are similar instructions on the net.

Jung-uk Kim