From owner-freebsd-current Wed Sep 20 0:17:53 2000 Delivered-To: freebsd-current@freebsd.org Received: from feral.com (feral.com [192.67.166.1]) by hub.freebsd.org (Postfix) with ESMTP id B32CB37B42C for ; Wed, 20 Sep 2000 00:17:49 -0700 (PDT) Received: from beppo.feral.com (beppo [192.67.166.79]) by feral.com (8.9.3/8.9.3) with ESMTP id AAA03468; Wed, 20 Sep 2000 00:14:30 -0700 Date: Wed, 20 Sep 2000 00:14:28 -0700 (PDT) From: Matthew Jacob Reply-To: mjacob@feral.com To: Poul-Henning Kamp Cc: current@FreeBSD.ORG Subject: Re: 1131 unneeded includes in the kernel... In-Reply-To: <94923.969433805@critter> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, 20 Sep 2000, Poul-Henning Kamp wrote: > In message , Matthew J > acob writes: > > > >How did you manage to generate this list. You're smoking > >crack on this one > > > >> dev/isp/isp_target.c > >> > >> > > > >as the isp_OS_PLATFORM.h includes is the only include this file has. > > Well, > > According to src/tools/tools/kerninclude that include is not even > needed. > > I'm not claiming that every single line is dogmatically true, but > at least it merits some amount of investigation... Sure. But your tool did not try the ISP_TARGET_MODE kernel option, which is what would then cause this file to even be compiled. The compile would fail, since 99% of all defined values, as in CT_SENDSTATUS and so on, are in files brought in by that header. I think I see what it is. The includes are outside the #ifdef ISP_TARGET_MODE but still.... As you say- merited investigation. Thanks. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message