From owner-svn-ports-head@FreeBSD.ORG Fri Oct 18 09:42:12 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id DF4E8F0D; Fri, 18 Oct 2013 09:42:12 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wg0-x229.google.com (mail-wg0-x229.google.com [IPv6:2a00:1450:400c:c00::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D87052024; Fri, 18 Oct 2013 09:42:11 +0000 (UTC) Received: by mail-wg0-f41.google.com with SMTP id b13so1834638wgh.2 for ; Fri, 18 Oct 2013 02:42:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=tZviBjBLRzFCrslyUUDPfgTJQ5d7BFDtA4qEHU2myx0=; b=QX4OnLRbTWxtSpnv1eIwvDDNuFsglv8uyfJ13NJafqHjPKATlBo35/12W+ednqAvob UlWWOYAR9KuWPeOCaWeqcTqekWSvhZwM5SXKHuzkKaZ6sYuIM6L1oRRw9qQEPFs1eXcm UDFX1eHlFJ44ZmSpHBzBwM3oIjj0uR40Fnk1nm84F8WyUxkXLoMM9gn9xnkLs3EeqpZ3 V8tSfLFwbsQSd9zAP8dpwOEoKVFLu8IZRg+WLjq4Yb+MGipC4WS/bi27ztyFLwV3n0he yFSW5RzO9hTPYEI1k6f8zgYR5H26HhWRvotAZIFV4S/Fl/nXjV8YYyywpaM13DoFmGfh gngQ== X-Received: by 10.194.104.66 with SMTP id gc2mr153910wjb.75.1382089330279; Fri, 18 Oct 2013 02:42:10 -0700 (PDT) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id fr4sm25243133wib.0.2013.10.18.02.42.09 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 18 Oct 2013 02:42:09 -0700 (PDT) Sender: Baptiste Daroussin Date: Fri, 18 Oct 2013 11:42:07 +0200 From: Baptiste Daroussin To: Oliver Lehmann Subject: Re: svn commit: r330725 - in head/games/heretic: . files Message-ID: <20131018094206.GJ42657@ithaqua.etoilebsd.net> References: <201310180705.r9I75eZV063407@svn.freebsd.org> <20131018075408.GI42657@ithaqua.etoilebsd.net> <20131018095930.Horde.738PZNGCU9PTyyjPK3vb3g1@avocado.salatschuessel.net> <5260ECEB.70302@marino.st> <20131018102511.Horde.6_u53MDsMxrI1SPe8hTA5Q3@avocado.salatschuessel.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="JsihDCElWRmQcbOr" Content-Disposition: inline In-Reply-To: <20131018102511.Horde.6_u53MDsMxrI1SPe8hTA5Q3@avocado.salatschuessel.net> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, marino@freebsd.org, John Marino , ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Oct 2013 09:42:13 -0000 --JsihDCElWRmQcbOr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 18, 2013 at 10:25:11AM +0200, Oliver Lehmann wrote: >=20 > John Marino wrote: >=20 > > Oliver, > > As I understand it, the original line only defines CC to "gcc" if CC is > > not present in the MAKE_ARGS. Thus bapt is correct, you don't need to > > patch this line. > > > > (In BSD make, it would be CC?=3Dgcc, but gmake looks at MAKE_ARGS) >=20 > Oups... I was under the impression it uses bmake but it uses indeed > GNU make. I'll recheck it and probably remove the patch. fmake, gmake and bmake works the same in that area. IIRC that is a POSIX make behaviour. Basically: Make first take the macros defined in arguments, then the one defined in the Makefile themself which cannot overwrite the first, then fallback on env wh= ich cannot overwrite the 2 previous. regards, Bapt --JsihDCElWRmQcbOr Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlJhAm4ACgkQ8kTtMUmk6EwMKgCggEdCtgQmyBCKAGS9oftQdkN0 U80AoJ2v0q8+DfMEAUXZfy7YKo4iUnZi =/Yyk -----END PGP SIGNATURE----- --JsihDCElWRmQcbOr--