Date: Wed, 1 Sep 2010 01:31:34 -0500 From: Scot Hetzel <swhetzel@gmail.com> To: bf1783@gmail.com Cc: maho@freebsd.org, freebsd-ports@freebsd.org Subject: Re: math/blas linking to gfortran with LDADD?= -lgfortran Message-ID: <AANLkTi=C-t6m_qSjOGVHETaSv=2hV7X1qkyaOSDD=Ecw@mail.gmail.com> In-Reply-To: <AANLkTin0HJCRUaJqepEESXJ8gO1qSpTx3dhfu6GnfNWZ@mail.gmail.com> References: <AANLkTinhAPY-PEH_TegMAEx1ejHf_WoEL8KZU%2BoXGhFD@mail.gmail.com> <4C7D76A6.7080401@DataIX.net> <AANLkTi=X6=o6bLy4EcGafiinK0UWjzUUPL6NNM6ad0i8@mail.gmail.com> <AANLkTinVXMOanGiMsBGBgyMtOWpDEUrLzaetZfFXn7p_@mail.gmail.com> <AANLkTin0HJCRUaJqepEESXJ8gO1qSpTx3dhfu6GnfNWZ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Aug 31, 2010 at 11:58 PM, b. f. <bf1783@googlemail.com> wrote: > On 9/1/10, Scot Hetzel <swhetzel@gmail.com> wrote: >> On Tue, Aug 31, 2010 at 10:06 PM, b. f. <bf1783@googlemail.com> wrote: >>> On 8/31/10, jhell <jhell@dataix.net> wrote: > >>So according to bsd.own.mk, this is the correct test for the math/blas >>port to determine if profiling libraries should be built: >> >>.if !defined(WITHOUT_PROFILE) >>PLIST_FILES+=3D =A0 lib/libblas_p.a >>.endif > > No, you are leaving the order out of account. =A0Apart from local and > custom makefiles, the makefiles are included so: > > /usr/share/mk/sys.mk > /etc/make.conf > /usr/share/mk/bsd.compat.mk > usr/share/mk/bsd.cpu.mk > Makefile(for math/blas) > /usr/share/mk/bsd.port.mk > /usr/share/mk/bsd.own.mk > /usr/ports/Mk/bsd.port.mk > /usr/ports/Mk/bsd.commands.mk > /usr/ports/Mk/bsd.perl.mk > /usr/ports/Mk/bsd.gcc.mk > /usr/ports/Mk/bsd.perl.mk > /usr/ports/Mk/bsd.licenses.mk > /usr/ports/Mk/bsd.sites.mk > ... > > So if NO_PROFILE or NOPROFILE is defined, a test for WITHOUT_PROFILE > in Makefile will still fail because NO_PROFILE is not mapped to > WITHOUT_PROFILE until bsd.own.mk, after the test. =A0Just be patient and > we'll sort it out. > >> >> As can be seen, NOPROFILE is deprecated. > > It may be deprecated, but it will still take effect without > BURN_BRIDGES, and so still must be accounted for. > >> >> NOTE: WITHOUT_PROFILE would need to be set in /etc/make.conf (instead >> of /etc/src.conf) to disable building profiled libraries in the >> FreeBSD sources and the math/blas port. > > No, it will still take effect, after the math/blas Makefile is parsed, > unless _WITHOUT_SRCCONF is defined. =A0See bsd.own.mk. > > b. > I created PR 150174, before I got your reply: http://www.freebsd.org/cgi/query-pr.cgi?pr=3D150174 I changed the port to use the OPTIONS framework to enable/disable profiled libraries. The only thing I didn't take into account was the bsd.lib.mk was still pulling in /etc/src.conf. To fix this we just need to add _WITHOUT_SRCCONF to the MAKE_ARGS (should they be MAKE_ENV?). Scot
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTi=C-t6m_qSjOGVHETaSv=2hV7X1qkyaOSDD=Ecw>