From owner-freebsd-arch@FreeBSD.ORG Sun Mar 17 15:59:36 2013 Return-Path: Delivered-To: freebsd-arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 69DD9DE2; Sun, 17 Mar 2013 15:59:36 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id 0C4DE81E; Sun, 17 Mar 2013 15:59:35 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.6/8.14.6) with ESMTP id r2HFxW7a081777; Sun, 17 Mar 2013 17:59:32 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.0 kib.kiev.ua r2HFxW7a081777 Received: (from kostik@localhost) by tom.home (8.14.6/8.14.6/Submit) id r2HFxW8U081776; Sun, 17 Mar 2013 17:59:32 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 17 Mar 2013 17:59:32 +0200 From: Konstantin Belousov To: Pawel Jakub Dawidek Subject: Re: chflagsat(2). Message-ID: <20130317155932.GS3794@kib.kiev.ua> References: <20130317004908.GB1364@garage.freebsd.pl> <20130317064338.GN3794@kib.kiev.ua> <20130317111931.GD1364@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XDVLi0tRPfHfrgwa" Content-Disposition: inline In-Reply-To: <20130317111931.GD1364@garage.freebsd.pl> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: freebsd-arch@FreeBSD.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Mar 2013 15:59:36 -0000 --XDVLi0tRPfHfrgwa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 17, 2013 at 12:19:31PM +0100, Pawel Jakub Dawidek wrote: > On Sun, Mar 17, 2013 at 08:43:38AM +0200, Konstantin Belousov wrote: > > On Sun, Mar 17, 2013 at 01:49:08AM +0100, Pawel Jakub Dawidek wrote: > > > Hi. > > >=20 > > > The following patch adds chflagsat(2) syscall to complete other *at > > > syscalls: > > >=20 > > > http://people.freebsd.org/~pjd/patches/chflagsat.patch > > >=20 > > > Note that the name chflagsat was carefully choosen instead of > > > fchflagsat, to not repeat POSIX (more likely Linux) mistakes of using > > > fchmodat, fchownat, futimesat, etc. names when they really shouldn't > > > start with an 'f'. > >=20 > > This is the only point I do not agree with the patch. I prefer to have > > the syscall name consistent with the other syscalls. >=20 > There are quite a few *at() syscalls and only few of them have bogus 'f' > prefix (fchmodat, fchownat, fstatat, futimesat). Most of them don't > (bindat, connectat, linkat, mkdirat, mkfifoat, mknodat, openat, > renameat, symlinkat, unlinkat). 'f' is of course bogus, because the > syscalls don't operate on descriptors, but on paths. chflagsat(2) is similar to fchmodat(2) and fchownat(2), this is why I noted about consistency. > Also note that POSIX is moving aways from those mistakes and eventhough > they standarized futimesat(), they now use utimensat() for nanosecond > precision timestamps to stop those mistakes. This is actually the > argument jilles' convinced me to use chflagsat instead of fchflagsat, > which is originally used. Ok. --XDVLi0tRPfHfrgwa Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJRRehjAAoJEJDCuSvBvK1BPJAP/2le60fPDO5kP1YdN+sZ+BR6 A8xCtPClAmKhS7Hxs1+1B+BLpdlkzaY7cbfqijndrEGCv0Nco/OJRJG25vurfxOt 0YKucm2k0sNW1sCF21bydlsxbrieZZg/KfZV48t2d8neLeeYj8DL84Llvo+usaW6 h3CJIjwiz/kQUgKKEWjUfK+6w1YY87QuYsu4mFA6me1zwyNj2Y4vNNyt8bRDQsMf YmVoxO6DLKfU5fCUeaveDEPmFeA8e1R4b2t8IKWy/btoeU6sFeA9fMjbyOY1SHRn 1+e/tA2WvD3wlb2TU9XGMYWAyj9KgEiqjQ87jrVF4hpyEFbVWoqQWhyFwE74PjtL 3NqQoN4vE5D/pa0yqymXJfYfp/dSqhvb02kQGW8okenQTGixEmTqCxpn/NhoAC+O YIPXCVSOa/WS6pmz17hFBJHyGwGRl3ZnO11icw1I7npzgYmSSD38RqDN9+N1RqmA Eysgt2tUZA4IvEBRJI7w8hB1Owvy7ncGTiWIfIKLomVPFYZB5wKa1o6aZSTGbel2 VgUWUnlR7u9I3Suqeoz/Hdp9emQwqKb+eyymeNruaAN0MXP8Qwh/DIbllh2yQNUC /TX+WeJ68N72gKYe4hCJUZb1yOeDAXR23AARIXulyq1h9bLSNrvWEOddOec1kn03 kKCpaAZArs2EtzNfjaKW =D15Y -----END PGP SIGNATURE----- --XDVLi0tRPfHfrgwa--