From owner-freebsd-ports@freebsd.org  Sat Sep 23 22:37:30 2017
Return-Path: <owner-freebsd-ports@freebsd.org>
Delivered-To: freebsd-ports@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 02852E121B1
 for <freebsd-ports@mailman.ysv.freebsd.org>;
 Sat, 23 Sep 2017 22:37:30 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3])
 by mx1.freebsd.org (Postfix) with ESMTP id E398B1EA7
 for <freebsd-ports@freebsd.org>; Sat, 23 Sep 2017 22:37:29 +0000 (UTC)
 (envelope-from adamw@adamw.org)
Received: by mailman.ysv.freebsd.org (Postfix)
 id DF861E121B0; Sat, 23 Sep 2017 22:37:29 +0000 (UTC)
Delivered-To: ports@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DF0F1E121AF
 for <ports@mailman.ysv.freebsd.org>; Sat, 23 Sep 2017 22:37:29 +0000 (UTC)
 (envelope-from adamw@adamw.org)
Received: from apnoea.adamw.org (apnoea.adamw.org [104.225.5.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "apnoea.adamw.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4DE3E1EA6;
 Sat, 23 Sep 2017 22:37:28 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id bd436aa4
 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO;
 Sat, 23 Sep 2017 16:37:27 -0600 (MDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: EXTRA_PATCHES considered harmful?
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <aab5d142-4e07-a4b2-1b92-bbc0778509a5@freebsd.org>
Date: Sat, 23 Sep 2017 16:37:24 -0600
Cc: "ports@FreeBSD.org" <ports@freebsd.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E67BEC92-E32A-4D61-A8CA-7BA2AD9ABC79@adamw.org>
References: <aab5d142-4e07-a4b2-1b92-bbc0778509a5@freebsd.org>
To: Julian Elischer <julian@freebsd.org>
X-Mailer: Apple Mail (2.3273)
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Sep 2017 22:37:30 -0000

> On 23 Sep, 2017, at 15:39, Julian Elischer <julian@freebsd.org> wrote:
>=20
> currently if you set EXTRA_PATCHES and the port you are making decides =
to build a second port as a dependency, EXTRA_PATCHES is passed to the =
second port which them obiously fails to patch it.
>=20
> e.g.  cd /usr/ports/emulators/open-vm-tools-nox11; Make =
EXTRA_PATCHES=3D/foo/bar/patch1
>=20
> will fail when it tries to apply the patch files to each dependency.
>=20
> AM I doing something wrong here?

Hi Julian,

I think EXTRA_PATCH_TREE is a better option for what you're looking for. =
You put patches in there in a tree that gets essentially overlaid on the =
ports tree.

EXTRA_PATCH_TREE=3D/usr/patches
Then put your patch1 in /usr/patches/emulators/open-vm-tools-nox11

# Adam


--=20
Adam Weinberger
adamw@adamw.org
https://www.adamw.org