Date: Sat, 13 Jun 2015 16:06:24 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: Craig Rodrigues <rodrigc@FreeBSD.org> Cc: "Simon J. Gerraty" <sjg@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Baptiste Daroussin <bapt@FreeBSD.org> Subject: Re: svn commit: r284345 - in head: . bin/cat bin/chflags bin/chio bin/chmod bin/cp bin/csh bin/date bin/dd bin/df bin/domainname bin/echo bin/ed bin/expr bin/freebsd-version bin/getfacl bin/hostname bi... Message-ID: <450D8D9A-CBF2-445A-8221-4CD353591549@gmail.com> In-Reply-To: <306889B5-3417-467C-965F-B011866E6F15@gmail.com> References: <201506131920.t5DJKwMH033508@svn.freebsd.org> <CAG=rPVfR3QbvYEM9Xdpxdhx_Aisj7Z0=mVig4HyUkk4uqQGrOg@mail.gmail.com> <950C4B23-B625-4173-A7C4-A4F1B2C5771D@gmail.com> <306889B5-3417-467C-965F-B011866E6F15@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_9194EFF1-7D74-4CBF-A687-D7E9F259969A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On Jun 13, 2015, at 15:46, Garrett Cooper <yaneurabeya@gmail.com> wrote: > On Jun 13, 2015, at 15:37, Garrett Cooper <yaneurabeya@gmail.com> = wrote: >=20 >> On Jun 13, 2015, at 15:34, Craig Rodrigues <rodrigc@FreeBSD.org> = wrote: >>=20 >>> On Sat, Jun 13, 2015 at 12:20 PM, Simon J. Gerraty <sjg@freebsd.org> = wrote: >>> Author: sjg >>> Date: Sat Jun 13 19:20:56 2015 >>> New Revision: 284345 >>> URL: https://svnweb.freebsd.org/changeset/base/284345 >>>=20 >>> Log: >>> Add META_MODE support. >>>=20 >>> Simon, >>>=20 >>> Can you take a look at this: >>> https://jenkins.freebsd.org/job/FreeBSD_HEAD/2860/ >>>=20 >>>=20 >>> The console output is showing this: >>> + make -j 4 buildworld __MAKE_CONF=3D/builds/FreeBSD_HEAD/make.conf >>> make: "/builds/FreeBSD_HEAD/Makefile" line 102: Malformed = conditional (${MK_META_MODE} =3D=3D "yes") >>> make: Fatal errors encountered -- cannot continue >>> make: stopped in /builds/FreeBSD_HEAD >>> Build step 'Execute shell' marked build as failure >>>=20 >>> This is using a FreeBSD 10.1 host to build HEAD. >>=20 >> The problem is that the bootstrapping capability has been broken with = fmake. The quick fix would probably be to add MK_META_MODE?=3D yes to = the Makefile. >>=20 >> We should probably keep the MK_ pollution in Makefile down to a = minimum because of bootstrapping issues like this though. >=20 > Great. More breakage: >=20 > $ fmake buildworld >=20 > -------------------------------------------------------------- >>>> Building an up-to-date bmake(1) > -------------------------------------------------------------- > "/usr/share/mk/bsd.links.mk", line 10: missing `in' in for > t in ${LINKS} > "/usr/share/mk/bsd.links.mk", line 13: for-less endfor > "/usr/share/mk/bsd.links.mk", line 14: missing `in' in for > t in ${SYMLINKS} > "/usr/share/mk/bsd.links.mk", line 17: for-less endfor > fmake: fatal errors encountered -- cannot continue > *** [bmake] Error code 1 >=20 > Stop in /usr/src.svn. > *** [upgrade_checks] Error code 1 >=20 > Stop in /usr/src.svn. This has been broken for a while with fmake: ------------------------------------------------------------------------ r280122 | bapt | 2015-03-15 14:50:58 -0700 (Sun, 15 Mar 2015) | 8 lines Symplify links installation by using multi variable for loop Using multi variable for loop not only simplify the code, it also = ensures that the LINKS and SYMLINKS input have the right number of words Differential Revision: https://reviews.freebsd.org/D2069 Reviewed by: imp --Apple-Mail=_9194EFF1-7D74-4CBF-A687-D7E9F259969A Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVfLdxAAoJEMZr5QU6S73e9eAIAJkgWwcxwwJK1OypGgRB816Q shPGZkOzsW84LJ7x7TgOYsjXzEiSD5DBOwe7vAam01wHqFvajprGK6mdu1XsdArA yCRUL+3nhbTQOdPjaTwLf6pnmjob7/h9psHHaBZET59rbcN+hIGx0hYsYNYFBn5G YTbC5OxfSlDSe22SqGEuyFOto2Z+9U2iWEKUesDsJcFw1FcLKnROVxJg36p2gt8p A7/63RLt3kBo1gXWxrOmbA6efcGu/R7RFQsOkvrniPIB9MXXveWXGsGn+Z2R8kGz ZmQaIF0jssUBKJnKoFgfbaXtmELaw9H/dkDmcusgjZ9tBfz+6WEJuG+2t4U04hw= =FE4L -----END PGP SIGNATURE----- --Apple-Mail=_9194EFF1-7D74-4CBF-A687-D7E9F259969A--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?450D8D9A-CBF2-445A-8221-4CD353591549>