From owner-freebsd-wireless@FreeBSD.ORG Thu Mar 15 08:05:35 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5AA1E106566B for ; Thu, 15 Mar 2012 08:05:35 +0000 (UTC) (envelope-from bschmidt@techwires.net) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id C7ECC8FC18 for ; Thu, 15 Mar 2012 08:05:34 +0000 (UTC) Received: by lboi15 with SMTP id i15so1710934lbo.13 for ; Thu, 15 Mar 2012 01:05:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:x-originating-ip:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding:x-gm-message-state; bh=OaJnQ3X6szSCmnMyfcjhDXU3JH0Z0nXOfLAHthdTFCQ=; b=ibQmrGU9OJ0szOHxEJtMO8/YVW0QJ3Yxe8udr5BTnZVdN+vww9gv72RR1HgMfo3j7/ tjfyT7KY3fNfKTDwzb7+GipDOSThh+WENsbjnGxHaT1fP7S3wuXXdPFZ4J/KcDeAlF13 fhr1mPkCPHRqLN5Gfck3bWBVZNC5jvP11pe3AypRMkaVNlF4AlYMrFUTWmg444Shwg7g 62hljO6OJqJ7QSncJ5E6v4M6IHUmtOuBsGfWJsI6Dnm/yTDcPy5UBX0FKR3l25acr9LV dXze4I5ImN13ZclRv8gakRGtwkkk2BCnFXk2J9SzEPQDu283bd2wlOGtddv+skG5DF3q bthA== MIME-Version: 1.0 Received: by 10.152.103.12 with SMTP id fs12mr4060517lab.47.1331798733617; Thu, 15 Mar 2012 01:05:33 -0700 (PDT) Sender: bschmidt@techwires.net Received: by 10.152.112.234 with HTTP; Thu, 15 Mar 2012 01:05:33 -0700 (PDT) X-Originating-IP: [79.140.39.245] In-Reply-To: <20120315.060358.41628027.iwasaki@jp.FreeBSD.org> References: <20120314.094656.92589124.iwasaki@jp.FreeBSD.org> <201203142031.41181.jhugo@meraka.csir.co.za> <20120315.060358.41628027.iwasaki@jp.FreeBSD.org> Date: Thu, 15 Mar 2012 09:05:33 +0100 X-Google-Sender-Auth: ArSJuAzR2XL2zMw5hiG2x3Dn_-s Message-ID: From: Bernhard Schmidt To: Mitsuru IWASAKI Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQmpgPoHaK4BXEu0ChhAJXihj9dqRSyfZ9mesRO891IeQfXBpYck5nVjRVG5DfD4Q4+zBi1L Cc: freebsd-wireless@freebsd.org Subject: Re: [patch] iwi(4) suspend/resume broken X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2012 08:05:35 -0000 On Wed, Mar 14, 2012 at 22:03, Mitsuru IWASAKI wro= te: > Hi, > >> Hi >> >> The wpi driver in 9.0 also suffers from a suspend/resume problem. Do you= think >> that you patch will fix the wpi driver as well ? > > Yes, I think so. =A0Please try the patch at: > http://people.freebsd.org/~iwasaki/wlan/wpi-20120315.diff > > The patch for ipw(4) also available, anyone try this? > http://people.freebsd.org/~iwasaki/wlan/ipw-20120315.diff > > Thanks! Hmm, I'm not sure I like this direct, unconditional fiddling with a VAP's state in the stop function, have you made sure that there are no side effects? eg. in case no VAP exists? I remember running into issue while doing that on iwn(4) and it helped to not have any knowledge about ic or vap in either init() or stop(). Well, I've settled for ieee80211_stop() and ieee80211_start() in suspend/resume, which seems to work. -- Bernhard