From owner-svn-ports-all@freebsd.org Fri Sep 4 15:32:45 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 56A2D9CAC64 for ; Fri, 4 Sep 2015 15:32:45 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 473A16C; Fri, 4 Sep 2015 15:32:45 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 46A0714F1; Fri, 4 Sep 2015 15:32:45 +0000 (UTC) Date: Fri, 4 Sep 2015 15:32:45 +0000 From: Alexey Dokuchaev To: Dirk Meyer Cc: svn-ports-all@freebsd.org Subject: Re: svn commit: r395527 - in head/graphics/jasper: . files Message-ID: <20150904153245.GA3009@FreeBSD.org> References: <201508290619.t7T6Js6d029551@repo.freebsd.org> <201508290619.t7T6Js6d029551@repo.freebsd.org> <20150829081543.GA8460@FreeBSD.org> <20150831062246.GA49457@FreeBSD.org> <20150904075918.GA30044@FreeBSD.org> <0OhphfKmbi@dmeyer.dinoex.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0OhphfKmbi@dmeyer.dinoex.sub.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Sep 2015 15:32:45 -0000 On Fri, Sep 04, 2015 at 04:29:10PM +0200, Dirk Meyer wrote: > > That's exactly what I'm talking about: for everyone except you, it looks > > wrong. People will keep fixing it. > > > > > I am also against sorting the Makefile lines by aplhabet. > > > $ sort Makefile | less > > > > I don't think anyone would even momentariry consider doing this. Why do > > you mention this idiocy? > > because I see no benefit in sorting by alphabet Mailefile lines, and > neither in sorting by alphabet USES= args. It is the same, it hides > functional ordering. It's ridiculous to compare sorting of USES to sorting of Makefile lines. In fact, USES do not imply any order, functional, sequential, or other. It is just a list of *.mk files to be picked up from Mk/Uses. If anyone relies on some specific order of those values they can be in big trouble. In make(1) world, the only correct way to establish operation order is by correctly and unambiguously defining targets' dependencies. As long as they're correct and coherent, actual order in USES does not matter, and it's just easier to maintain when it's sorted alphabetically. ./danfe