From owner-cvs-all@FreeBSD.ORG Tue Jul 19 08:45:50 2011 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 6FF8E106564A; Tue, 19 Jul 2011 08:45:50 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 65-241-43-4.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 20E3414E1E5; Tue, 19 Jul 2011 08:45:49 +0000 (UTC) Message-ID: <4E25443D.8080306@FreeBSD.org> Date: Tue, 19 Jul 2011 01:45:49 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:5.0) Gecko/20110706 Thunderbird/5.0 MIME-Version: 1.0 To: Jaap Akkerhuis References: <201107152055.p6FKt0ap062328@repoman.freebsd.org> <4E20C588.5010409@FreeBSD.org> <201107180906.p6I96cSH033317@bartok.nlnetlabs.nl> In-Reply-To: <201107180906.p6I96cSH033317@bartok.nlnetlabs.nl> X-Enigmail-Version: 1.2pre OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org, Julien Laffaye Subject: Re: cvs commit: ports/dns/opendnssec Makefile distinfo pkg-plist ports/dns/opendnssec/files opendnssec.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2011 08:45:50 -0000 On 07/18/2011 02:06, Jaap Akkerhuis wrote: > Hi Doug, > > I've attached some (hopefully) improvements to the rc.d script. First > the minor issues: > > 1. It needs a $FreeBSD$ > > Oops, didn't realise that. > > 2. We prefer ports scripts to REQUIRE: LOGIN unless there is a reason it > needs to start earlier. > > Yes, I was wondering whether I should do that or not. > > 3. Minor typo and whitespace twiddles > > More substantively, I compressed the start_ and stop_ methods, but this > should be tested. It certainly _should_ work. :) It's fine to have all > the extra_commands, but they won't be functional unless they also have > methods associated with them. Finally, I left the procname assignment in > there, but it's not at all clear to me where $opendnssec_procname is > defined, or what that procname is going to be used for. It can probably > just be deleted. > > Thanks a bunch. I'll test this out to be sure. Yes you might have > guessed, I incoporated this from a user who apparently based this > on the nsd rc.d script. I'll have a look at that one as well. Yeah, I figured that. :) The nsd script actually doesn't look too bad, but I'd add "KEYWORD: shutdown" when you have a chance. Especially since nsd has some stuff that it needs to do to shut down cleanly (although I highly recommend this for any script that starts a persistent service). hth, Doug -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/