Date: Mon, 23 Sep 2002 20:06:05 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: Jeff Roberson <jeff@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/sys vnode.h Message-ID: <20020923200021.A17417-100000@gamplex.bde.org> In-Reply-To: <71508.1032765948@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 23 Sep 2002, Poul-Henning Kamp wrote: > In message <200209230721.g8N7LQeF079924@freefall.freebsd.org>, Jeff Roberson wr > ites: > >jeff 2002/09/23 00:21:26 PDT > > > > Modified files: > > sys/sys vnode.h > > Log: > > - Include sys/ktr.h so that vnode_if.h can define trace points. > > Wouldn't it make more sense to #include it in vnode_if.h ? This would be slightly worse since the namespace pollution is 1 level deeper. It is equivalent in practice since vnode_if.h is unusable without vnode.h and vice versa (module the bugs that vnode.h is included in applications and the new include isn't under a _KERNEL ifdef). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020923200021.A17417-100000>