From owner-cvs-all  Mon Sep 23  2:57:23 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id F046C37B401; Mon, 23 Sep 2002 02:57:22 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id AC08743E42; Mon, 23 Sep 2002 02:57:21 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id TAA24393;
	Mon, 23 Sep 2002 19:57:11 +1000
Date: Mon, 23 Sep 2002 20:06:05 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Poul-Henning Kamp <phk@critter.freebsd.dk>
Cc: Jeff Roberson <jeff@FreeBSD.org>, <cvs-committers@FreeBSD.org>,
	<cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/sys/sys vnode.h 
In-Reply-To: <71508.1032765948@critter.freebsd.dk>
Message-ID: <20020923200021.A17417-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Mon, 23 Sep 2002, Poul-Henning Kamp wrote:

> In message <200209230721.g8N7LQeF079924@freefall.freebsd.org>, Jeff Roberson wr
> ites:
> >jeff        2002/09/23 00:21:26 PDT
> >
> >  Modified files:
> >    sys/sys              vnode.h
> >  Log:
> >   - Include sys/ktr.h so that vnode_if.h can define trace points.
>
> Wouldn't it make more sense to #include  it in vnode_if.h ?

This would be slightly worse since the namespace pollution is 1 level
deeper.  It is equivalent in practice since vnode_if.h is unusable
without vnode.h and vice versa (module the bugs that vnode.h is
included in applications and the new include isn't under a _KERNEL
ifdef).

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message