From owner-svn-ports-all@FreeBSD.ORG Fri May 8 16:03:45 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0CD91976 for ; Fri, 8 May 2015 16:03:45 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C8E591C3A for ; Fri, 8 May 2015 16:03:44 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t48G3iBK009276 for ; Fri, 8 May 2015 16:03:44 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t48G3iIc009272 for svn-ports-all@freebsd.org; Fri, 8 May 2015 16:03:44 GMT (envelope-from bdrewery) Received: (qmail 50260 invoked from network); 8 May 2015 11:03:40 -0500 Received: from unknown (HELO ?10.10.1.139?) (freebsd@shatow.net@10.10.1.139) by sweb.xzibition.com with ESMTPA; 8 May 2015 11:03:40 -0500 Message-ID: <554CDE6C.6000302@FreeBSD.org> Date: Fri, 08 May 2015 11:03:56 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Mathieu Arnold , Sunpoet Po-Chuan Hsieh CC: Matthew Seaman , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r385776 - in head/sysutils: . rubygem-hiera-file References: <201505081305.t48D5ULi055835@svn.freebsd.org> <554CD6C9.5000708@FreeBSD.org> <554CDBE8.7020703@FreeBSD.org> <5AA4F2DD682E895BAD92C3A8@atuin.in.mat.cc> In-Reply-To: <5AA4F2DD682E895BAD92C3A8@atuin.in.mat.cc> OpenPGP: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WX63iLUJPgd43L26vqAHCEgLp0713WVe1" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 May 2015 16:03:45 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WX63iLUJPgd43L26vqAHCEgLp0713WVe1 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 5/8/2015 11:00 AM, Mathieu Arnold wrote: > +--On 8 mai 2015 10:53:12 -0500 Bryan Drewery wr= ote: > |>=20 > |> % portlint -abct > |> WARN: Makefile: Consider defining LICENSE. > |> WARN: Makefile: "RUN_DEPENDS" has to appear earlier. > |> 0 fatal errors and 2 warnings found. > |=20 > | This rule serves no purpose. >=20 > I don't really agree, from make's point of view, it does not, but from = the > point of view of us all having to maintain a bunch of Makefiles, if the= > order of the group of fields is always consistent, it's easier to read.= >=20 But it's not, and it's not possible to do so. Consider OPTION-based DEPENDS. See www/nginx/Makefile as an example. This rule will never be consistent and it's a pointless rule that serves only to annoy people. --=20 Regards, Bryan Drewery --WX63iLUJPgd43L26vqAHCEgLp0713WVe1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVTN5sAAoJEDXXcbtuRpfPmD4H/1aPHtQbUAQtBPBHCpBu/TO5 WkmrQwA3OKpRBGZGf2pOcdotCWwYIyy18yVA+gKN/wxMTS9LPNKKY7d9FsDTbfI/ DcNqmLNGv9B9flQEntcZYxlztRw4ez1lxsd/yE45KXkuLvVN2pYOwhA5e5/0TkNX DoK/rsGVPUulUwBAsTTUdWKpQ7x8xWSZPsHdCNV5JtzwC3JZXIPZC93pWMMqIWYS JOEgRsd+vZ69UqKxeXs7sKUOlBsvLw0u4BkaCvJSCLvencf//Kp85X85fGZ0wW+l gWHpc0CHsrsLf4X9E1j3vtxWt5wPXC5wz83uZOVIOfvsj1/OWTRiRj4rYwrM4U0= =yTZe -----END PGP SIGNATURE----- --WX63iLUJPgd43L26vqAHCEgLp0713WVe1--