Date: Mon, 30 Dec 2002 00:38:10 -0500 From: Craig Rodrigues <rodrigc@attbi.com> To: David Schultz <dschultz@uclink.Berkeley.EDU> Cc: current@FreeBSD.ORG, sparc64@FreeBSD.ORG Subject: Re: sparc64 tinderbox failure Message-ID: <20021230053810.GA79308@attbi.com> In-Reply-To: <20021230051705.GA5307@HAL9000.homeunix.com> References: <200212300321.gBU3LMWB011861@bowie.private> <20021229202731.B22633@citusc.usc.edu> <20021230051705.GA5307@HAL9000.homeunix.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Dec 29, 2002 at 09:17:05PM -0800, David Schultz wrote:
> Thus spake Kris Kennaway <kris@citusc.usc.edu>:
> > On Mon, Dec 30, 2002 at 03:21:22AM +0000, Mike Barcroft wrote:
> >
> > > ===> sbin/swapon
> > > cc1: warnings being treated as errors
> > > /tinderbox/sparc64/src/sbin/swapon/swapon.c: In function `swaplist':
> > > /tinderbox/sparc64/src/sbin/swapon/swapon.c:246: warning: field width is not type int (arg 3)
> >
> > Can someone please just fix this (by backing out the offending commit,
> > if necessary)?
>
> Eek, given a 64-bit size_t, the present code leaves 32 bits of it
> uninitialized in the usual case. The following patch ought to fix
> the problem; I can't make sure right now because I'm out of town.
I'm not sure if your patch will solve the problem.
The offending code is here:
240 if (lflag) {
241 char buf[32];
242 snprintf(buf, sizeof(buf), "%ld-blocks", blocksize);
243 printf("%-13s %*s %*s\n",
244 "Device:",
245 hlen, buf,
246 hlen, "Used:");
247 }
Doesn't the printf() statement in question have the wrong number of
arguments?
--
Craig Rodrigues
http://www.gis.net/~craigr
rodrigc@attbi.com
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021230053810.GA79308>