Date: Wed, 03 Mar 1999 22:32:17 +0900 From: Kazutaka YOKOTA <yokota@zodiac.mech.utsunomiya-u.ac.jp> To: "Gary Palmer" <gpalmer@freebsd.org> Cc: cvs-committers@freebsd.org, cvs-all@freebsd.org, yokota@zodiac.mech.utsunomiya-u.ac.jp Subject: Re: cvs commit: src/usr.sbin/moused moused.c Message-ID: <199903031332.WAA11172@zodiac.mech.utsunomiya-u.ac.jp> In-Reply-To: Your message of "Mon, 01 Mar 1999 12:52:00 EST." <88161.920310720@gjp.erols.com> References: <88161.920310720@gjp.erols.com>
next in thread | previous in thread | raw e-mail | index | archive | help
>> But, I wonder if the correct fix is to merge the following to >> src/sys/alpha/include/mouse.h... > >I thought about that, but last night when I was doing this is seemed to make >more sense to me to not have a USB define on a platform that doesn't have USB. > >However, I'm not 100% sure that either is the right solution :) Probably a >placeholder of some sort needs to go into alpha/include/mouse.h to say that >the USB interface is reserved. Comments? True that alpha doesn't have USB. But, USB itself is not dependent on any platform. Reserving it in all platform makes sense to me. The constant MOUSE_IF_USB in question is returned from the device driver and there is no other use. It won't be much of a problem if we refer to it even on the platforms which don't presently have USB; no driver will return this value. Yes, few lines of code will be wasted on these platforms, but they are not much, are they? There should be a header for mouse definitions in a machine-independent place. The content of i386/include/mouse.h (and its almost-identical twin, alpha/include/mouse.h) is already pretty much machine-independent... Kazu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199903031332.WAA11172>