Date: Tue, 13 Jul 2010 12:48:52 -0700 (PDT) From: Doug Barton <dougb@FreeBSD.org> To: gahr@FreeBSD.org Cc: cvs-ports@FreeBSD.org, Alexey Dokuchaev <danfe@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/gdcm distinfo Message-ID: <alpine.BSF.2.00.1007131240010.1703@qbhto.arg> In-Reply-To: <20100713144735.GK48019@gahrfit.gahr.ch> References: <201007131351.o6DDpcmT044616@repoman.freebsd.org> <20100713144320.GA95556@FreeBSD.org> <20100713144735.GK48019@gahrfit.gahr.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 13 Jul 2010, Pietro Cerutti wrote: > Sure, "tarball rerolled" was meant to do just that :) The way this is usually done is to indicate in the commit message that you reviewed the diff between the old tarball and the new one, and a brief statement to describe what changed, and whether or not the change affected the installed version of the port. If the latter is true, a PORTREVISION bump is in order as well. This has nothing to do with whether or not we trust you to do your job. The commit logs serve (at least) 2 primary purposes. To let people know today what changed (briefly) and more importantly _why_ something changed. The other important purpose is to let people know what and why years from now, when no one remembers you. :) Another function that commit logs serve, and it's arguable whether or not it's a primary function, is to serve as an example to those who are reading them. We may all trust that YOU understand what "tarball rerolled" means, and why, but for someone new to the project who is going to be a committer someday, you want to set a good example. Based on what you said later in the thread a reasonable commit message might have been something like, "Tarball rerolled for a minor documentation update, no functional changes." hth, Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ Computers are useless. They can only give you answers. -- Pablo Picasso
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1007131240010.1703>