From owner-freebsd-ports@FreeBSD.ORG Wed Dec 16 10:09:43 2009 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5E13B106566B for ; Wed, 16 Dec 2009 10:09:43 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.156]) by mx1.freebsd.org (Postfix) with ESMTP id A79A18FC19 for ; Wed, 16 Dec 2009 10:09:42 +0000 (UTC) Received: by fg-out-1718.google.com with SMTP id 16so694304fgg.13 for ; Wed, 16 Dec 2009 02:09:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=CpiSf8diypYUjFP7kRo1tdR99Fgb2Ct1ulK5q9WcwnU=; b=BPP6R7tGLP890SfwUZRVHNRJviC/rji3aR0bVq8wM88JYAC9qQ2e5XmZQs+5MQpt+e BE9GHXONAOhxwElPsIcmiILzw+Wav9Cpfp4M9yEj1fi7JMk6/aOnwQ7tHa+noFqds+e2 +D3mGnf5zSis+G9tXRA2IYlevILBA3cACLSZo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=UCexbccBygbde2dLuZGgL1iursL0v+cDyukQmGRpO3dBicUFAb23hZ4K/bezJOhS8t U4BsujKVcD9LXBm+aLo3iRPzdG4cNqUj/K83kum07sdDkj+8A4X5XjTzhvEN/nDzOyiJ VNDK6l789MDm0ngDPplXYtJNtqeMKxE00r/DI= MIME-Version: 1.0 Received: by 10.86.235.14 with SMTP id i14mr1044322fgh.52.1260958180990; Wed, 16 Dec 2009 02:09:40 -0800 (PST) In-Reply-To: References: <20091214151318.GC1016@wicklow.lan> Date: Wed, 16 Dec 2009 10:09:40 +0000 Message-ID: From: Baptiste Daroussin To: freebsd-ports@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: New version of the fakeroot patch X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Dec 2009 10:09:43 -0000 > I don't know if this should be a port setting. I think this should be > a user setting. So, I think WITH_FAKE / WITH_FAKEROOT is a better > choice. Obviously ports not working with fakeroot would have to define > something like IGNORE_FAKEROOT, the same kind of variable we have for > MAKE_JOBS. > I note this and will make the modifications to do that. (next patch should be next year) > > I'm thinking files could be moved from the fakeroot directory instead > of copied, that way you could run 'find ${FAKEDIR} ! -type d' and find > out if you've missed anything. > I have to think about this, but yes that could be the right thing to do. > > On pointyhat, a package will be generated at the end regardless. Also, > quite a lot of tools do make a package backup before deinstalling, so > I don't see this as a major issue. If people don't like the I/O > overhead, we could use pkg_add in slave mode, it will skip the package > building phase. > I agree with that > > As I mentioned it before, I think it's a very valuable feature to have. > > -- > Florent Thoumie > flz@FreeBSD.org > FreeBSD Committer > Thanks for your feedback, I'll send a new version of the patch soon.