Date: Sun, 15 May 2016 10:45:57 -0600 From: Ian Lepore <ian@freebsd.org> To: Garrett Cooper <ngie@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r299839 - head/etc/rc.d Message-ID: <1463330757.1180.154.camel@freebsd.org> In-Reply-To: <201605150438.u4F4coNR080598@repo.freebsd.org> References: <201605150438.u4F4coNR080598@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 2016-05-15 at 04:38 +0000, Garrett Cooper wrote: > Author: ngie > Date: Sun May 15 04:38:50 2016 > New Revision: 299839 > URL: https://svnweb.freebsd.org/changeset/base/299839 > > Log: > Make FILESYSTEMS, dumpon, and var not depend on zfs and zvol > > Make zfs and zvol come before all of the items that depended on > them > previously > I'm trying to figure out why these changes are needed. rcorder works just fine when a requirement has no providers (yes, it whines, but that's why /etc/rc invokes it with 2>/dev/null). If FILESYSTEMS requires zfs and nothing provides zfs, then it's as if the requirement weren't in the list at all. The manpage for rcorder is wrong, the DIAGNOSTICS section implies that rcorder will abort on a missing requirement, but it doesn't. Changing requirements to BEFOREs seems like it has a lot of potential for messing with peoples' out-of-tree customizations. (And for some reason I've always had the impression that BEFORE was to be avoided in the base rc files, but I can't remember why I think that.) -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1463330757.1180.154.camel>