From owner-cvs-all@FreeBSD.ORG Tue May 8 21:50:00 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 231AE16A402; Tue, 8 May 2007 21:50:00 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id F2D9413C48C; Tue, 8 May 2007 21:49:59 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l48Lnxnx061130; Tue, 8 May 2007 21:49:59 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l48LnxIp061129; Tue, 8 May 2007 21:49:59 GMT (envelope-from jhb) Message-Id: <200705082149.l48LnxIp061129@repoman.freebsd.org> From: John Baldwin Date: Tue, 8 May 2007 21:49:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern kern_condvar.c kern_synch.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2007 21:50:00 -0000 jhb 2007-05-08 21:49:59 UTC FreeBSD src repository Modified files: sys/kern kern_condvar.c kern_synch.c Log: Fix a potential LOR with sx_sleep() and cv_wait() with sx locks by 1) adding the thread to the sleepq via sleepq_add() before dropping the lock, and 2) dropping the sleepq lock around calls to lc_unlock() for sleepable locks (i.e. locks that use sleepq's in their implementation). Revision Changes Path 1.61 +25 -5 src/sys/kern/kern_condvar.c 1.294 +7 -1 src/sys/kern/kern_synch.c