Date: Thu, 14 Jul 2005 16:47:32 +0200 From: Tilman Linneweh <tilman+2005-07-14@arved.at> To: Robert Watson <rwatson@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys malloc.h src/sys/kern kern_malloc.c Message-ID: <20050714144732.GA62728@arved.at> In-Reply-To: <200507141152.j6EBq6x2065276@repoman.freebsd.org> References: <200507141152.j6EBq6x2065276@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Robert Watson [Thu, 14 Jul 2005 at 13:52 GMT]: > rwatson 2005-07-14 11:52:06 UTC > > FreeBSD src repository > > Modified files: > sys/sys malloc.h > sys/kern kern_malloc.c > Log: [..] > While here: > > - Bump statistics width to uint64_t, and hard code using fixed-width > type in order to be more sure about structure layout in the stream. > We allocate and free a lot of memory. > [..] >| @@ -686,10 +689,10 @@ sysctl_kern_malloc(SYSCTL_HANDLER_ARGS) >| temp_bytes = 0; >| >| /* >| - * XXXRW: High-waterwark is no longer easily available, so >| - * we just print '-' for that column. >| + * High-waterwark is no longer easily available, so we just >| + * print '-' for that column. >| */ >| - sbuf_printf(&sbuf, "%13s%6lu%6luK -%9lu", >| + sbuf_printf(&sbuf, "%13s%6lu%6luK -%9llu", >| mtp->ks_shortdesc, >| temp_allocs, >| (temp_bytes + 1023) / 1024, This does not compile on amd64. /usr/src/sys/kern/kern_malloc.c: In function `sysctl_kern_malloc': /usr/src/sys/kern/kern_malloc.c:699: warning: long long unsigned int format, uint64_t arg (arg 6) regards tilman
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050714144732.GA62728>