Skip site navigation (1)Skip section navigation (2)
Date:      Wed,  6 Nov 2013 07:37:20 +0000 (UTC)
From:      "Ganael LAPLANCHE" <martymac@FreeBSD.org>
To:        Mathieu Arnold <mat@FreeBSD.org>, Ganael LAPLANCHE <martymac@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r332820 - head/archivers/par2cmdline
Message-ID:  <20131106073557.M24176@FreeBSD.org>
In-Reply-To: <8CC47BFA1B6ED1DA41489582@atuin.in.mat.cc>
References:  <201311050813.rA58Dx1d073265@svn.freebsd.org> <8CC47BFA1B6ED1DA41489582@atuin.in.mat.cc>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 05 Nov 2013 09:34:00 +0100, Mathieu Arnold wrote

Hi Mathieu,

> You can also remove the .if ... .endif, as only files in the 
> plist are installed after staging.

Mmmhh, it makes check-orphans fail and think a few files are left ;
moreover the target's purpose is more clear this way, isn't it ?

> And I think you should use INSTALL_DATA, as it's clearly not a
> man page :-)

Yep, fixed, thanks !

Best regards,

--
Ganael LAPLANCHE <ganael.laplanche@martymac.org>
http://www.martymac.org | http://contribs.martymac.org
FreeBSD: martymac <martymac@FreeBSD.org>, http://www.FreeBSD.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131106073557.M24176>