Date: Tue, 11 Oct 2011 21:00:50 -0700 From: Kevin Oberman <kob6558@gmail.com> To: "Kenneth D. Merry" <ken@freebsd.org> Cc: ports@freebsd.org Subject: Re: audio/cdparanoia broken on -CURRENT, and probably on 9.0 Message-ID: <CAN6yY1s4%2B_qcJZVRE_ffcNq9NsjRJLchUXsiBNKgCu1DKm_4rA@mail.gmail.com> In-Reply-To: <20111012033304.GA48367@nargothrond.kdm.org> References: <CAN6yY1vFXNRjGyA2NHtGcMhvgueRLvV=QeAYj6y1Qf1PjU1OrA@mail.gmail.com> <20111012033304.GA48367@nargothrond.kdm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 11, 2011 at 8:33 PM, Kenneth D. Merry <ken@freebsd.org> wrote: > On Tue, Oct 11, 2011 at 15:52:35 -0700, Kevin Oberman wrote: >> > On Fri, Oct 07, 2011 at 03:46:22 -0400, b. f. wrote: >> > > Just a note to say that recent changes on -CURRENT (r225950, meaning >> > > that it is probably broken on 9.0 after r226067) have broken >> > > audio/cdparanoia, and it should be fixed or marked as BROKEN there. = =A0I >> > > haven't filed a PR, or attempted to patch it yet -- I think that it >> > > would be worthwhile to look into moving to 10.2, which has a large >> > > number of improvements, although suffering from some Linuxisms. >> > >> > This will be easy to patch, using one of two methods: >> > >> > =A0- change struct scsi_sense_data to struct scsi_sense_data_fixed >> > or, better yet: >> > =A0- use scsi_extract_sense_len(), which will work for fixed or descri= ptor sense. >> >> Ken, >> >> OK. I have grepped through all of the cdparanoia sources and fine no >> instances of scsi_sense_data. Where in the heck do I find it so I can >> get this port built? 10.2 would be lovely, but I just need cdparanoia >> on 9-stable quickly and I fear that hte package will no longer work >> after r226067. > > There is no FreeBSD support in cdparanoia by default. =A0It is patched in= by > the ports system. > > Go into the directory for the port, do a 'make fetch' and then 'make patc= h'. > > Then go into cdparanoia-III-alpha9.8/interface and copy the attached file > on top of scsi_interface.c. > > I've checked that it compiles on a system running code before the change, > but I think that change should work for systems before or after the chang= e. > > Let me know whether it works for you. Thanks so much! Yes, the new scsi_interface.c compiled cleanly and cdparanoia built and installed. I am in the process of re-building all ports after I upgraded my system to 9-stable, so I really can't plug in my CD and try ripping aomething right now, but I'll try soonand let you know how it worked. Thanks again! --=20 R. Kevin Oberman, Network Engineer E-mail: kob6558@gmail.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAN6yY1s4%2B_qcJZVRE_ffcNq9NsjRJLchUXsiBNKgCu1DKm_4rA>