Date: Tue, 1 May 2018 12:53:32 -0600 From: Warner Losh <imp@bsdimp.com> To: David Cross <dcrosstech@gmail.com> Cc: Kyle Evans <kevans@freebsd.org>, FreeBSD Hackers <freebsd-hackers@freebsd.org>, Devin Teske <dteske@freebsd.org> Subject: Re: Bug 207069 (loader password kills boot) Message-ID: <CANCZdfoCh-bkfc90gfQgOm-AK8HLOZxEk01_UJvvCsZ-TKo-tA@mail.gmail.com> In-Reply-To: <BBFD5A99-23FA-462B-AA23-EFF5B75C56EA@gmail.com> References: <7630266D-D078-41B3-BC27-32EBF65540C4@gmail.com> <CACNAnaEEd_DoJg_9B=Y2GuL=R40ShTA27fgXis3jMiSgVdN9-A@mail.gmail.com> <CANCZdfr0pRiN08ZVn%2B2x%2BTk6suAbkg7Ui_X-9S=E14WfqDFMYg@mail.gmail.com> <CACNAnaGmHK1WoXHX2rvJR=50p%2B1gX72M7%2BM-KH5YzET=e48_UQ@mail.gmail.com> <BBFD5A99-23FA-462B-AA23-EFF5B75C56EA@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, May 1, 2018 at 12:49 PM, David Cross <dcrosstech@gmail.com> wrote: > From my investigation when I wrote the patch originally the problem is (a= s > I recall, its been awhile) the forth dictionary space is limited so parts > are flushed out (that is the only section at the top) additional > dictionaries are then explicitly loaded (the also sections. The load_kern= el > and load_modules are needed from the support-functions dictionaries > That matches my reading of the also clause. Thanks. > As for why this is now needed here, there was a change made ~2 years ago > to defer loading the kernel until the system was just about to boot (afte= r > beastie menu vs before). Autoboot assumes that kernel is loaded and will > not load for you. Making it load for you conflicts with the menu loading > it. So it password is enabled menu and kernel loading doesn=E2=80=99t hap= pen. This > reatores that and puts it right before autoboot (which is a C portion of > loader) > OK. That gives me something to go on to look at things more closely. > (Going off of memory from ~2 years ago) > > Apologies for naming the patch works for me. This wasn=E2=80=99t just sla= p it in > where it worked, i spent a good amount of time digging into what changed, > why, and to maintain the desired flow, OK. That also helps. Thanks for taking the time to dust off the memories. Warner > > On May 1, 2018, at 14:22, Kyle Evans <kevans@freebsd.org> wrote: > > > >> On Tue, May 1, 2018 at 1:17 PM, Warner Losh <imp@bsdimp.com> wrote: > >> > >> > >>> On Tue, May 1, 2018 at 12:12 PM, Kyle Evans <kevans@freebsd.org> > wrote: > >>> > >>>> On Tue, May 1, 2018 at 1:07 PM, David Cross <dcrosstech@gmail.com> > wrote: > >>>> The aforementioned bug has been open for over 2 years, with attached > and > >>>> tested patches. At least one other has commented. > >>>> > >>>> Could we please have it for 11.2/12.0? > >>> > >>> Hi, > >>> > >>> CC'ing Devin, our local Forth-fu-fighter. If it looks ok to Devin, on= e > >>> of us should go ahead and shuffle this through. > >> > >> > >> Yes. I've looked at this code a fair amount, and I don't understand wh= y > this > >> is needed and why it would make things work. Since it is a security > thing, > >> I'm very reluctant to push it in absent better understanding of why it > >> works. > >> > > > > Right, it also confuses me. =3D) > > > > When I was implementing this stuff for Lua, autoboot DTRT as long as > > module_path is setup correctly -- this is probably the part that's > > missing since IIRC that's usually done in menu setup (that doesn't > > happen here). > > > > I'm not sure if this the right way to fix it in Forth-land, though. >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoCh-bkfc90gfQgOm-AK8HLOZxEk01_UJvvCsZ-TKo-tA>