Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 3 Jul 2000 14:22:43 +0100 (BST)
From:      Nick Hibma <n_hibma@calcaphon.com>
To:        Poul-Henning Kamp <phk@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/sys bus.h bus_private.h src/sys/kern       subr_bus.c
Message-ID:  <Pine.BSF.4.20.0007031415520.20669-100000@localhost>
In-Reply-To: <200007031306.GAA10432@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
I object to it.

This is going to bite us, with people allocating the softc when it is
not necessary, duplicating code and fragmenting memory fragmenting. I
don't see why you can't do with a reference to the correct softc in your
device softc instead of this hack.

Apart from that, where is the manpage for it? We have an alomst complete
set at the moment and I would like to keep it that way.  Please make
sure you mention that this method should only be called in rare cases
where the softc allocated by the newbus system would not do for some
obscure reason.

Nick

> phk         2000/07/03 06:06:32 PDT
> 
>   Modified files:
>     sys/sys              bus.h bus_private.h 
>     sys/kern             subr_bus.c 
>   Log:
>   Add device_set_softc() which does the obvious.
>   
>   Not objected to by:	dfr
>   
>   Revision  Changes    Path
>   1.36      +2 -1      src/sys/sys/bus.h
>   1.16      +2 -1      src/sys/sys/bus_private.h
>   1.73      +22 -8     src/sys/kern/subr_bus.c
> 
> 
> 

--
n_hibma@webweaving.org
n_hibma@freebsd.org                                          USB project
http://www.etla.net/~n_hibma/



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.20.0007031415520.20669-100000>