From owner-cvs-all Mon Jul 3 6:40:21 2000 Delivered-To: cvs-all@freebsd.org Received: from anchor-post-34.mail.demon.net (anchor-post-34.mail.demon.net [194.217.242.92]) by hub.freebsd.org (Postfix) with ESMTP id 131B537B5B7; Mon, 3 Jul 2000 06:40:10 -0700 (PDT) (envelope-from n_hibma@qubesoft.com) Received: from calcaphon.demon.co.uk ([193.237.19.5] helo=bluebottle.qubesoft.com) by anchor-post-34.mail.demon.net with esmtp (Exim 2.12 #1) id 1396S5-0003yj-0Y; Mon, 3 Jul 2000 14:40:01 +0100 Received: from henny.webweaving.org (henny.qubesoft.com [192.168.1.5]) by bluebottle.qubesoft.com (8.9.3/8.9.1) with ESMTP id OAA46116; Mon, 3 Jul 2000 14:39:36 +0100 (BST) (envelope-from n_hibma@qubesoft.com) Received: from localhost (localhost [127.0.0.1]) by henny.webweaving.org (8.9.3/8.9.3) with ESMTP id OAA20695; Mon, 3 Jul 2000 14:22:43 +0100 (BST) (envelope-from n_hibma@qubesoft.com) Date: Mon, 3 Jul 2000 14:22:43 +0100 (BST) From: Nick Hibma X-Sender: n_hibma@localhost Reply-To: Nick Hibma To: Poul-Henning Kamp Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys bus.h bus_private.h src/sys/kern subr_bus.c In-Reply-To: <200007031306.GAA10432@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG I object to it. This is going to bite us, with people allocating the softc when it is not necessary, duplicating code and fragmenting memory fragmenting. I don't see why you can't do with a reference to the correct softc in your device softc instead of this hack. Apart from that, where is the manpage for it? We have an alomst complete set at the moment and I would like to keep it that way. Please make sure you mention that this method should only be called in rare cases where the softc allocated by the newbus system would not do for some obscure reason. Nick > phk 2000/07/03 06:06:32 PDT > > Modified files: > sys/sys bus.h bus_private.h > sys/kern subr_bus.c > Log: > Add device_set_softc() which does the obvious. > > Not objected to by: dfr > > Revision Changes Path > 1.36 +2 -1 src/sys/sys/bus.h > 1.16 +2 -1 src/sys/sys/bus_private.h > 1.73 +22 -8 src/sys/kern/subr_bus.c > > > -- n_hibma@webweaving.org n_hibma@freebsd.org USB project http://www.etla.net/~n_hibma/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message