From owner-freebsd-x11@freebsd.org Wed Feb 20 21:20:48 2019 Return-Path: Delivered-To: freebsd-x11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E601F14DCC32 for ; Wed, 20 Feb 2019 21:20:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 7C6096F403 for ; Wed, 20 Feb 2019 21:20:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 3BEE314DCC31; Wed, 20 Feb 2019 21:20:47 +0000 (UTC) Delivered-To: x11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2910314DCC30 for ; Wed, 20 Feb 2019 21:20:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B664D6F400 for ; Wed, 20 Feb 2019 21:20:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id E10DD1279A for ; Wed, 20 Feb 2019 21:20:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x1KLKjn0084453 for ; Wed, 20 Feb 2019 21:20:45 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x1KLKjL4084447 for x11@FreeBSD.org; Wed, 20 Feb 2019 21:20:45 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: x11@FreeBSD.org Subject: [Bug 235886] [patch] x11-clocks/xclock: update to 1.0.8; add missing dependencies and LICENSE Date: Wed, 20 Feb 2019 21:20:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: samy.mahmoudi@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: x11@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 21:20:48 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D235886 --- Comment #7 from Samy Mahmoudi --- (In reply to Niclas Zeising from comment #6) I just had a look at bsd.port.mk and bsd.xorg.mk. We could stay to: XORG_CAT=3D app USES=3D iconv USE_XORG=3D xrender xft xkbfile xt xaw or we could go for: USES=3D iconv XORG_CAT=3D app USE_XORG=3D xrender xft xkbfile xt xaw or even: XORG_CAT=3D app USES=3D iconv USE_XORG=3D xrender xft xkbfile xt xaw These blocks would have the same effect: XORG_CAT only needs to be before USE_XORG, as you suggested. But which style do you prefer (in case we submit patches for portlint and the handbook) ? IMHO, we should mention XORG_CAT directly before USE_XORG (second alternati= ve) to avoid duplication of Xorg-related variables, as in: XORG_CAT=3D app USES=3D iconv USE_SOMETHING=3D USE_SOMETHING=3D USE_SOMETHING=3D USE_SOMETHING=3D USE_SOMETHING=3D USE_XORG=3D xrender xft xkbfile xt xaw --=20 You are receiving this mail because: You are the assignee for the bug.=