Date: Wed, 28 Apr 2004 14:52:39 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Ruslan Ermilov <ru@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/boot/i386/boot0 Makefile boot0.sboot0_512.s boot0sio.s Message-ID: <20040428144757.T4950@gamplex.bde.org> In-Reply-To: <20040427192403.GC75827@ip.net.ua> References: <200404271907.i3RJ7ZkI028848@repoman.freebsd.org> <20040427192403.GC75827@ip.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 27 Apr 2004, Ruslan Ermilov wrote: > On Tue, Apr 27, 2004 at 12:07:35PM -0700, Poul-Henning Kamp wrote: > > phk 2004/04/27 12:07:35 PDT > > > > FreeBSD src repository > > > > Modified files: > > sys/boot/i386/boot0 Makefile > > Added files: > > sys/boot/i386/boot0 boot0_512.s > > Removed files: > > sys/boot/i386/boot0 boot0.s boot0sio.s > > Log: > > Change from '#' to "//" comment character to allow CPP preprocessing. > > > This is backwards, please fix. Also, the preprocessed files So "# foo" is a valid comment and not a preprocessor directive in *.S provided "foo" is not a standard preprocessor directive? This could be used to back out the mess made by translating the comments in /sys/i386/i386/*.s to C comments. The assembler files in /sys/i386 were also the main ones with the wrong file extension until the boot code regressed. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040428144757.T4950>