From owner-cvs-src@FreeBSD.ORG Tue May 1 10:26:24 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DB6ED16A400; Tue, 1 May 2007 10:26:24 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 4D7A213C457; Tue, 1 May 2007 10:26:24 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l41AQMeg006105; Tue, 1 May 2007 14:26:22 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l41AQMXB006104; Tue, 1 May 2007 14:26:22 +0400 (MSD) (envelope-from ache) Date: Tue, 1 May 2007 14:26:22 +0400 From: Andrey Chernov To: Peter Jeremy Message-ID: <20070501102621.GA6002@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Peter Jeremy , Alfred Perlstein , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <20070430180043.GK13868@elvis.mu.org> <20070430181824.GA83415@nagual.pp.ru> <20070430225717.GA7008@VARK.MIT.EDU> <20070501000242.GA19510@nagual.pp.ru> <20070501100642.GB823@turion.vk2pj.dyndns.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5mCyUwZo2JvN/JJP" Content-Disposition: inline In-Reply-To: <20070501100642.GB823@turion.vk2pj.dyndns.org> User-Agent: Mutt/1.5.15 (2007-04-06) Cc: cvs-src@FreeBSD.org, Alfred Perlstein , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 10:26:25 -0000 --5mCyUwZo2JvN/JJP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 01, 2007 at 08:06:42PM +1000, Peter Jeremy wrote: > I would have expected this proposed change to get a heads-up in > current@ first. _Especially_ since there is a current thread in > current@ about fixing some long-standing memory leaks in our *env() > functions. Implementing a major POLA violation without any warning > whilst other changes to the same code are being discussed in one of > the mailing lists could be seen as impolite. I see no POLA violations from my own.=20 1) POLA for those functions is well known while internal hacks can't be=20 called POLA. 2) Our putenv() itself is ist originating POLA violation since=20 implemented, so we just returning to original POLA. My changes are not related to fixing some long-standing memory leaks in=20 our *env() at all, I don't touch that code so can't change the same code=20 as other. > >There is no SVR4 bugs in this commit. >=20 > The SVR4 behaviour (as documented in SUSv3) is a bug. If you mean putenv() (I see no other things which can be called SVR4=20 behaviour there), it isn't BSD native function, so we must honor its=20 original implementation, if we decide to provide it. > Note that the C90 (ANSI X3.159-1989, ISO 9899:1990) does not include > putenv() or setenv() due to the the lack of any concensus on how they > should behave. =20 I know. > FreeBSD does not and (AFAIK) has never claimed to be to-the-letter POSIX= =20 > compliance by default. See and count our manpages, namely STANDARDS section. The question again: what isn't working currently _for_you? --=20 http://ache.pp.ru/ --5mCyUwZo2JvN/JJP Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.3 (FreeBSD) iD8DBQFGNxXNVg5YK5ZEdN0RAh2jAJ4vAHknCCV+WCXYqgIMzfH9NX40lgCeKOtP sPAdomcaEe6YIyC32iIGtQw= =Sc+j -----END PGP SIGNATURE----- --5mCyUwZo2JvN/JJP--