Date: Wed, 5 Feb 2014 16:56:38 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r342718 - head/audio/libmad Message-ID: <20140205155638.GJ23872@ithaqua.etoilebsd.net> In-Reply-To: <20140205165319.06494484@kalimero.tijl.coosemans.org> References: <201402051529.s15FTbbV098516@svn.freebsd.org> <0807AAFF65F7176953AA8581@ogg.in.absolight.net> <3A1E876406193F10101E533D@ogg.in.absolight.net> <20140205165319.06494484@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--NqSa+Xr3J/G6Hhls Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 05, 2014 at 04:53:19PM +0100, Tijl Coosemans wrote: > On Wed, 05 Feb 2014 16:38:41 +0100 Mathieu Arnold wrote: > > +--On 5 f=E9vrier 2014 16:35:22 +0100 Mathieu Arnold <mat@FreeBSD.org> = wrote: > >| +--On 5 f=E9vrier 2014 15:29:37 +0000 Sunpoet Po-Chuan Hsieh > >| <sunpoet@FreeBSD.org> wrote: > >|| Author: sunpoet > >|| Date: Wed Feb 5 15:29:37 2014 > >|| New Revision: 342718 > >|| URL: http://svnweb.freebsd.org/changeset/ports/342718 > >|| QAT: https://qat.redports.org/buildarchive/r342718/ > >||=20 > >|| Log: > >|| - Use USES=3Dlibtool > >||=20 > >|| Modified: > >|| head/audio/libmad/Makefile > >||=20 > >|| Modified: head/audio/libmad/Makefile > >|| =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >|| =3D=3D=3D=3D=3D --- head/audio/libmad/Makefile Wed Feb 5 15:29:04 20= 14 (r342717) > >|| +++ head/audio/libmad/Makefile Wed Feb 5 15:29:37 2014 (r342718) @@ > >|| -15,8 +15,8 @@ SPEED_DESC=3D Optimize for speed over accu > >|| =20 > >|| CONFIGURE_ARGS=3D --disable-debugging --enable-sso > >|| GNU_CONFIGURE=3D yes > >|| -USE_AUTOTOOLS=3D libtool > >|| USE_LDCONFIG=3D yes > >|| +USES=3D libtool > >|| =20 > >|| SUB_LIST=3D VERSION=3D${PORTVERSION} > >|| SUB_FILES=3D mad.pc > >||=20 > >|=20 > >| I'm quite sure you forgot to update the plist. > >=20 > > And quite possibly bump PORTREVISION in the ports that depend on it. >=20 > USES=3Dlibtool also decrements the library version in this case which > should be avoided, so you have to patch the port to decrement age until > the library version is the same as before. I've attached a patch which > does this. I don't think we should avoid decrementing shlib numbers in that case we are going back to normal situation just it needs to be chased, in my opinion. BTW: I have committed a fix regards, Bapt --NqSa+Xr3J/G6Hhls Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlLyXzYACgkQ8kTtMUmk6EzMkwCfZQwJ22kcHq6eD8VLnYXqgapo JtEAoKZ8B/MZm7n8WH+m+b5dgdBxA0vs =l+dx -----END PGP SIGNATURE----- --NqSa+Xr3J/G6Hhls--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140205155638.GJ23872>