Date: Sat, 26 May 2018 20:20:38 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r470615 - head Message-ID: <20180526182038.qhim5e6zpaqabna6@atuin.in.mat.cc> In-Reply-To: <alpine.LSU.2.21.1805261634080.3624@anthias.pfeifer.com> References: <201805221358.w4MDwYtl021212@repo.freebsd.org> <alpine.LSU.2.21.1805261634080.3624@anthias.pfeifer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--zbbqyj76grnbv6km Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 26, 2018 at 02:36:51PM +0000, Gerald Pfeifer wrote: > On Tue, 22 May 2018, Mathieu Arnold wrote: > > New Revision: 470615 > > URL: https://svnweb.freebsd.org/changeset/ports/470615 > >=20 > > Log: > > Don't tell people to use @${FLAVOR} in that case, it's bad practice. >=20 > I'm picking this as one example of various I've seen (from various > committers, not meaning to single you out, Mathieu): >=20 > When going through a commit history at a later point to look for > something specific, understand the evolution of code, or to simply > better understand a commit, good commit messages are paramount. >=20 > The above, and unfortunately many others, do not really help much. >=20 > (What is "this case"? Why is it bad practice? ...) I thought I had written a verbose commit message, I usually do. They do not have the same purpose, the idea is that: - FLAVOR is the flavor of the current port, it only has a purpose locally in the port, it can be used to change the port behavior, like turning features on or off or whatever. - PY_FLAVOR is the current Python flavor is the current PHP flavor, or any other *_FLAVOR framework defined variable, it can be influenced by the local FLAVOR, so that they match, but it they may not be related at all. Its purpose is to be consistent when requiring dependencies, to make sure the port gets the correct flavor for what it needs. --=20 Mathieu Arnold --zbbqyj76grnbv6km Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAABCgBmBQJbCaV2XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I4FcP/1MFfKgD7jmUFhcf8Xtw4soJ cKe+wcqPmGp1x6WwJvup02Sxz+un2e49VQf/xcr/VuaXvJ/uaYf7hAyYHoVXJdPS isDKRUuETWJRMX4kVAwoYZDhFxwSwZHR20rAqECP9UAjp5kKFPCm6egT3Wuibr4Y 0utNhmNHt7Ue15MWxwPH2Q1BfWUXrYhfYaA7giSejJk2ZEQZEYD97kECslCB43/H IMSeUVmmGNMofHaCDs6cV0sr7rVBuSddlxTyNoZlkXM3DYJ/iEi5fYmmaT0+SEpC ir2IQmt46/lNMsZFjz3Qv5sNeaZO9nE78fi/+Is4vGPHxYU9kAR6Pc5Do2XiNxYn rIXKXVJPv9dDLOcv/eZLNH396CMhGwFDe8zDo2tVPyI6OwrcSw1POqHKMZ+9jMl2 Fq4XdYVrMNQrpxJu+sNDCAjvxFM6RGp+XXpcJR7QnRZcPYhQjbHJ0tvLmLMoDWxJ 6SC4TWx+9/iQbAhmcwI6sEABN9WmygSKq1oPGlaDccTv8VFEzfUMQukederUggFg 2uYHV6qOYjonvEnmdw1deC1gsUMgdpoE9adnA41LtT5X4vjxGyzR+8OMASMn6VH/ eScv3Mh3+aSUTqVCKWynp2RVI79EDzyhgKWO4kRGWQ1EpVOJXCSb1VNawojSXAPL mwPEG44fkq5qboOvsJB8 =9MUT -----END PGP SIGNATURE----- --zbbqyj76grnbv6km--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180526182038.qhim5e6zpaqabna6>