Date: Fri, 24 Feb 2017 12:58:19 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Eric van Gyzen <vangyzen@FreeBSD.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r314179 - in head: contrib/netbsd-tests/lib/librt include lib/libc/gen lib/libc/include share/man/man3 sys/kern Message-ID: <067FDB11-2808-4F27-AAEA-5595207749D4@gmail.com> In-Reply-To: <20170224144329.GA13444@FreeBSD.org> References: <201702231936.v1NJadRa029404@repo.freebsd.org> <CAGHfRMCyyWc7OYXnh3R247ouJR9vG-8_55N9z_kzipEdHVZzkA@mail.gmail.com> <31cd29ad-6c34-f3d0-b71c-04857b013d02@FreeBSD.org> <20170224144329.GA13444@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_B7987210-E34E-483A-8533-89AE065E84B4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Feb 24, 2017, at 6:43 AM, Alexey Dokuchaev <danfe@FreeBSD.org> = wrote: >=20 > On Fri, Feb 24, 2017 at 08:22:21AM -0600, Eric van Gyzen wrote: >> By the way, have you considered adding a Herald rule on Phabricator? >> Phab is not perfect, but a lot of folks use it, and the Herald rules >> are a very effective way to watch them play in one's area. >=20 > +1, we need more Herald rules to make Phabricator more efficient. Of > course there are #manpages or #network groups, but often it is a bit > hard to come up with whom you'd want to place on the review list (like > if MAINTAINERS does not mention who's responsible and/or willing to > review the code you touch, and obviously you don't want to annoy some > random people just because you think they are technically qualified > enough or have required domain knowledge). Sending "Hey check this = out > guys, Dxxxx" emails on e.g. -hackers@ is not a good option either (as > it would annoy even more people). Yes, I have been looking into Herald(/MAINTAINERS integration): = https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217316 = <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217316>; . I=E2=80=99v= e put up a series of rules for contrib/netbsd-tests and *.test.mk, so = I=E2=80=99ll at least be pinged when changes are made to these areas. Thanks, -Ngie --Apple-Mail=_B7987210-E34E-483A-8533-89AE065E84B4 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYsJ5tAAoJEPWDqSZpMIYVMzoP/0tuECQ+7ot4hFqEprcQ2A1B kdF/9qQxXAkaVxBDOzRqhyO1ltMZBJ7rpg0SKMq/RdCYcJRuFtZ1WZMwHSlM+C29 iR422TlB9YXbnNQIaB64W9/lcjyRo7lQvAPOspntopAazVSEgAokzRZR8l1caJaA S+fDW6cofFrITOqVSjWXhIHPhSmCgEjKSeH54wiGEuzJmn6ptBa/pBhcu8+2bAZq 3ZCyogq1A1VGSYIwEPdMZ4JYc1fgk2i604en2HRJI6k4fNityXqxQ2cnHZkoqRmF 5caCq/tnKDNb4xEI98FGRp68ob8xrUYM+DRuwRjtSwXRGF7lXON2F+7gP7uqbAJp hJ8CUxhdWvCOGBp1QpuCntti0WctGTApZ+p/KpU566Rpls6zfFyfSQiXO1j2OdyW Ill/YSuQIVryZ1qHrSHYI47bvbuG0qWtFYJLAvz3YzOOn3y4EaoPGsDMGJRSEilE PSh9HyYz9OkxIDBI457EozDtn5rh3dcx0SEwSk3Jj3SBvDJT/4nyfvk+y6SdFMSL gLvqrsDhGmEUiCd6YD8RUEzBEXAAKJmCHkvSUC7XUmh5iFa1BeYMP7d3fLvBNKEi YG1m1HwRKeD2sdHXrtxBoP7Yy9zhntcfS/8riTTKTRwSkASj8m3VyyKM3aDuwVAA meVEc/hBhTKYB9hg5xW9 =TNi2 -----END PGP SIGNATURE----- --Apple-Mail=_B7987210-E34E-483A-8533-89AE065E84B4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?067FDB11-2808-4F27-AAEA-5595207749D4>