Date: Fri, 3 Apr 2015 16:39:32 -0400 From: Ed Maste <emaste@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, FreeBSD Toolchain <freebsd-toolchain@freebsd.org> Subject: Re: Failed to build rescue with gcc 4.9 Message-ID: <CAPyFy2DPMRYkH=hYvPCoaoG2e0FEb8CDagQN2_%2BdygRRmtU-ug@mail.gmail.com> In-Reply-To: <2D2191D4-DB6F-4889-9CA9-DFEE495D8302@bsdimp.com> References: <CAG=rPVeUQ0mm8JKEWDcdw2trqOrUtDx0pGwm8FqbEzuf9P39rA@mail.gmail.com> <CAG=rPVcfUFme=9BzTHCKtV2bT8ASHX0JPcczp343mjE9=Kfoug@mail.gmail.com> <CAG=rPVeYShPad4KXr1uzczZJ0-_vBytSRArw7wGk_8VZF1vm1A@mail.gmail.com> <2D2191D4-DB6F-4889-9CA9-DFEE495D8302@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3 April 2015 at 13:02, Warner Losh <imp@bsdimp.com> wrote: > That shows that something in the list is needed. Likely only crunchhide. > > It doesn=E2=80=99t tell us why we need it, or when we started needing it,= or what > other conditions we might need it. This information is critical to docume= nt > so we know when we can stop doing it in the future. I=E2=80=99m extremely= reluctant > to commit this until we know these details. Yes, it's crunchide. It was broken prior to r277259: | crunchide: Correct 64-bit section header offset | | For 64-bit binaries the Elf_Ehdr e_shoff is at offset 40, not 44. | Instead of using an incorrect hardcoded offset, let the compiler | figure it out for us with offsetof(). | | Differential Revision: https://reviews.freebsd.org/D1543 It's not completely clear to me why we did not encounter this before; a comment before the erroneous write states: /* * update the offset of section header table in elf * header if needed. */ so I presume something about the object file created by gcc 4.9 causes this code to be executed, while builds using the in-tree compiler did not.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2DPMRYkH=hYvPCoaoG2e0FEb8CDagQN2_%2BdygRRmtU-ug>