Date: Sun, 31 Jul 2005 10:23:43 +0200 From: Alexander Leidinger <netchild@FreeBSD.org> To: des@des.no (Dag-Erling =?ISO-8859-1?Q?Sm=F8rgrav?=) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Peter Grehan <grehan@FreeBSD.org>, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 ObsoleteFiles.inc src/share/man/man7 build.7 Message-ID: <20050731102343.35bc4aa9@Magellan.Leidinger.net> In-Reply-To: <863bpvmnww.fsf@xps.des.no> References: <200507292145.j6TLjkNc099549@repoman.freebsd.org> <86k6j8g7mq.fsf@xps.des.no> <20050730124053.507227dd@Magellan.Leidinger.net> <863bpvmnww.fsf@xps.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 31 Jul 2005 09:31:59 +0200
des@des.no (Dag-Erling Sm=F8rgrav) wrote:
> Alexander Leidinger <netchild@FreeBSD.org> writes:
> > What's more preferred, the use of ".error", or the way you solved it?
>=20
> depends on what you think should happen if a user tries
>=20
> # make installworld delete-old
Ok, point taken.
> BTW, I don't really see why {check,delete}-old-* should be restricted
> to native environments. DESTDIR might point to e.g. an NFS-exported
> filesystem from which thin clients of a different architecture boot.
Because of ObsoleteFiles.inc:
---snip---
.if ${MACHINE_ARCH} !=3D "alpha" && ${MACHINE_ARCH} !=3D "sparc64"
# 20040130: libkse renamed to libpthread
OLD_FILES+=3Dusr/lib/libkse.a
OLD_FILES+=3Dusr/lib/libkse.so
.endif
---snip---
We could change this to TARGET_ARCH instead, but then the user has to
set it, else he removes non-obsolete files. Even when we make it a
documented requirement, I don't have a good feeling regarding this.
There's too much foot-shooting potential if someone forgets to set it.
I think it's more user friendly / ergonomic to keep the current
restriction. With the restriction in place you need to have 2
files (Makefile.inc1 and ObsoleteFiles.inc) or the NFS exported src
directory on one client to remove the old files. This is a little bit
more work, but forces the administrator to think a little bit about what
he does. It's part of my "as failsafe as possible" design of this
feature.
I don't object when someone wants to remove the restriction based upon
a decission of a majority (committers, user complains, whatever).
Bye,
Alexander.
--=20
Where do you think you're going today?
http://www.Leidinger.net Alexander @ Leidinger.net
GPG fingerprint =3D C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050731102343.35bc4aa9>