From owner-cvs-src@FreeBSD.ORG  Wed Jan 31 16:23:50 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 7CFD616A406;
	Wed, 31 Jan 2007 16:23:50 +0000 (UTC)
	(envelope-from gallatin@cs.duke.edu)
Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1])
	by mx1.freebsd.org (Postfix) with ESMTP id 3DCA513C4A8;
	Wed, 31 Jan 2007 16:23:50 +0000 (UTC)
	(envelope-from gallatin@cs.duke.edu)
Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30])
	by duke.cs.duke.edu (8.13.6/8.13.6) with ESMTP id l0VGNnnP005975
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO);
	Wed, 31 Jan 2007 11:23:49 -0500 (EST)
Received: (from gallatin@localhost)
	by grasshopper.cs.duke.edu (8.12.9p2/8.12.9/Submit) id l0VGNiuZ036183; 
	Wed, 31 Jan 2007 11:23:44 -0500 (EST) (envelope-from gallatin)
From: Andrew Gallatin <gallatin@cs.duke.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <17856.49808.122662.571245@grasshopper.cs.duke.edu>
Date: Wed, 31 Jan 2007 11:23:44 -0500 (EST)
To: Scott Long <scottl@samsco.org>
In-Reply-To: <45C0BC2F.9060303@samsco.org>
References: <200701311547.l0VFliLC039432@repoman.freebsd.org>
	<45C0BC2F.9060303@samsco.org>
X-Mailer: VM 6.75 under 21.1 (patch 12) "Channel Islands" XEmacs Lucid
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/mxge if_mxge.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Jan 2007 16:23:50 -0000


Scott Long writes:
 > Yeah, I can't stress enough that busdma maps are opaque handles and
 > should always be handled like they are valid.  It's only an
 > implementation detail that they are often NULL on i386 and amd64.

It was overly cautious resource freeing code, influenced by lots
of programming on other OSes, where free(NULL) is a panic :(
I was able to simplify it some..

FWIW, I've got one small leak of 2 "temp" items left that I'm going to
wait for dtrace to track down.

Drew