Date: Mon, 25 Jul 1994 09:58:11 -0700 (PDT) From: phk@tfs.com (Poul-Henning Kamp) To: rgrimes@gndrsh.aac.dev.com (Rodney W. Grimes) Cc: phk@freefall.cdrom.com, ache@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-lib@freefall.cdrom.com, davidg@freefall.cdrom.com, dyson@freefall.cdrom.com, jkh@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, nate@freefall.cdrom.com, paul@freefall.cdrom.com, pst@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, sean@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, wollman@freefall.cdrom.com Subject: Re: cvs commit: src/lib/libmd .depend Message-ID: <m0qSTLv-0003xQC@TFS.COM> In-Reply-To: <199407250523.WAA24861@gndrsh.aac.dev.com> from "Rodney W. Grimes" at Jul 24, 94 10:23:39 pm
next in thread | previous in thread | raw e-mail | index | archive | help
> And note.. this was a trivial thing that really does not warrant review, > but be thinking about haveing all changes reviewed... so you can fill > in BOTH lines... and probably stop a lot of bad commits. That is what > I believe Garrett had in mind when he added the rcstemplate stuff. I think I must have misunderstood you when we talked about it then. I thought the Reviewed by line was supposed to be there >in any case< as "who to point the gun at". Garretts CVS-INFO makes this somewhat clearer, but I still miss the "step-by-step manual". For instance Garrett insist that libmd should have been "cvs add"'ed instead of imported. I disagree. If libmd had had just a couple of subdirs that would have been a royal pain to do, with much bigger risk of errors. I'd like to restate my caution against the "2nd system syndrome" again: I know that we had a couple of bad commits during before 2.0, but we should NOT make it too difficult for people to submit changes, or FreeBSD will stall. We have to make an tradeoff here. I'm all for reviews, except they should be swift and not hold up things which are OK. -- Poul-Henning Kamp <phk@login.dkuug.dk> TRW Financial Systems, Inc. FreeBSD has, until now, not one single time had an undetected error. :-)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?m0qSTLv-0003xQC>