From owner-freebsd-current@FreeBSD.ORG Mon Mar 29 23:42:12 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7BB0716A4CE for ; Mon, 29 Mar 2004 23:42:12 -0800 (PST) Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B48043D49 for ; Mon, 29 Mar 2004 23:42:12 -0800 (PST) (envelope-from rizzo@icir.org) Received: from xorpc.icir.org (localhost [127.0.0.1]) by xorpc.icir.org (8.12.9p1/8.12.8) with ESMTP id i2U7gCgd073244; Mon, 29 Mar 2004 23:42:12 -0800 (PST) (envelope-from rizzo@xorpc.icir.org) Received: (from rizzo@localhost) by xorpc.icir.org (8.12.9p1/8.12.3/Submit) id i2U7gCP3073243; Mon, 29 Mar 2004 23:42:12 -0800 (PST) (envelope-from rizzo) Date: Mon, 29 Mar 2004 23:42:12 -0800 From: Luigi Rizzo To: Marcel Moolenaar Message-ID: <20040329234212.A72990@xorpc.icir.org> References: <20040329163926.A38109@xorpc.icir.org> <20040330005013.GA53546@ns1.xcllnt.net> <20040329230643.B70930@xorpc.icir.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20040329230643.B70930@xorpc.icir.org>; from rizzo@icir.org on Mon, Mar 29, 2004 at 11:06:43PM -0800 cc: current@freebsd.org Subject: Re: proposed bsdlabel patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Mar 2004 07:42:12 -0000 actually, following up to myself: you do need some way to disambiguate between the case of a device ("bsdlabel ad0") and a file in the current directory ("bdslabel ad0"). This is why i introduced '-f' in the first place, and I think either that or requiring absolute pathnames for files cannot go away. As to which one is preferrable i am neutral. Note that there are several utilities which have the same problem with ambiguous command line syntax. cheers luigi On Mon, Mar 29, 2004 at 11:06:43PM -0800, Luigi Rizzo wrote: > On Mon, Mar 29, 2004 at 04:50:13PM -0800, Marcel Moolenaar wrote: > > On Mon, Mar 29, 2004 at 04:39:26PM -0800, Luigi Rizzo wrote: > > > if there are no strong objections, I'd like to commit > > > the following minor patch to bsdlabel (and associated bsdlabel.8 > > > changes) to implement a '-f' option which enables bsdlabel to > > > work on an image file too. > > > > As Julian mentioned, why not use stat(2) and DTRT without options? > > That also removes the gratuitous requirement that the filename has > > to be an absolute path. See also the implementation of gpt(8)... > > sure, will do that, and take care of the style bugs as bruce > suggested (the original patch was voluntarily formatted in > a way to reduce the diffs). > > thanks for the feedback > cheers > luigi > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"