From owner-p4-projects@FreeBSD.ORG  Wed Dec  3 16:22:44 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 2BB3A16A4D0; Wed,  3 Dec 2003 16:22:44 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from green.bikeshed.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id B917616A4CE; Wed,  3 Dec 2003 16:22:43 -0800 (PST)
Received: from green.bikeshed.org (green@localhost [127.0.0.1])
	by green.bikeshed.org (8.12.10/8.12.9) with ESMTP id hB3H0srB001186;
	Wed, 3 Dec 2003 12:00:54 -0500 (EST)
	(envelope-from green@green.bikeshed.org)
Received: from localhost (green@localhost)hB3H0saN001182;
	Wed, 3 Dec 2003 12:00:54 -0500 (EST)
Message-Id: <200312031700.hB3H0saN001182@green.bikeshed.org>
X-Mailer: exmh version 2.6.3 04/04/2003 with nmh-1.0.4
To: Peter Wemm <peter@FreeBSD.org>
In-Reply-To: Message from Peter Wemm <peter@FreeBSD.org> 
	<200312030112.hB31CUMd091141@repoman.freebsd.org> 
From: "Brian F. Feldman" <green@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Wed, 03 Dec 2003 12:00:53 -0500
Sender: green@green.bikeshed.org
cc: Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 43329 for review 
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Dec 2003 00:22:44 -0000

Peter Wemm <peter@FreeBSD.org> wrote:
> http://perforce.freebsd.org/chv.cgi?CH=43329
> 
> Change 43329 by peter@peter_overcee on 2003/12/02 17:12:26
> 
> 	grrr. this is totally broken if you have a serial console
> 	attached and as the primary console, as it prevents ddb
> 	starting up if you crash while running X on the syscons
> 	console.

How about we change them all to do something like this?  Yes, I'm aware that 
it contains levels of bogosity.  I'd actually rather change 
consdev::cn_flags to have a flag for CN_FLAG_UNAVAIL, and then cnunavail() 
would be easier to call "correctish".

(tty_cons.c)
int
cnunavail(void)
{
	struct cn_device *cnd;

	cnd = STAILQ_FIRST(&cn_devlist);
	return (cnd == NULL || (cons_unavail && 
	    bcmp(cnd->cn_name, "ttyv", 4) == 0));
}

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green@FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\