Date: Mon, 17 Nov 2014 18:28:24 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: "Alexander V. Chernikov" <melifaro@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r274585 - head/sys/net Message-ID: <20141117152824.GQ1031@FreeBSD.org> In-Reply-To: <20141117152740.GP1031@FreeBSD.org> References: <201411161456.sAGEuWVj029737@svn.freebsd.org> <20141117152740.GP1031@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Nov 17, 2014 at 06:27:40PM +0300, Gleb Smirnoff wrote: T> On Sun, Nov 16, 2014 at 02:56:32PM +0000, Alexander V. Chernikov wrote: T> A> Author: melifaro T> A> Date: Sun Nov 16 14:56:31 2014 T> A> New Revision: 274585 T> A> URL: https://svnweb.freebsd.org/changeset/base/274585 T> A> T> A> Log: T> A> Make witness happy: destroy rte lock before free. T> A> MFC after: 2 weeks T> A> Modified: T> A> head/sys/net/route.c T> A> T> A> Modified: head/sys/net/route.c T> A> ============================================================================== T> A> --- head/sys/net/route.c Sun Nov 16 13:57:53 2014 (r274584) T> A> +++ head/sys/net/route.c Sun Nov 16 14:56:31 2014 (r274585) T> A> @@ -517,6 +517,7 @@ rtfree(struct rtentry *rt) T> A> /* T> A> * and the rtentry itself of course T> A> */ T> A> + RT_LOCK_DESTROY(rt); T> A> uma_zfree(V_rtzone, rt); T> A> return; T> A> } T> T> This is not right fix. The lock will be destroyed second time by rtentry_zfini(). T> T> Can you please point me at revision that introduced the problem, you are T> trying to solve? Please ignore me. :) A lag between our yesterday IRC discussion and email. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141117152824.GQ1031>