From owner-freebsd-current@FreeBSD.ORG Sat Dec 6 16:50:39 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5861B482; Sat, 6 Dec 2014 16:50:39 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BE18C798; Sat, 6 Dec 2014 16:50:38 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id sB6GoSR9043129 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 6 Dec 2014 18:50:28 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua sB6GoSR9043129 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id sB6GoS9j043127; Sat, 6 Dec 2014 18:50:28 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 6 Dec 2014 18:50:28 +0200 From: Konstantin Belousov To: Dimitry Andric Subject: Re: Build failed in Jenkins: Build-UFS-image #599 Message-ID: <20141206165027.GJ97072@kib.kiev.ua> References: <1052304530.8.1417827164793.JavaMail.jenkins@jenkins-9.freebsd.org> <7A7677F9-AD1B-436C-9A49-054F7CD6BBC4@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7A7677F9-AD1B-436C-9A49-054F7CD6BBC4@FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: FreeBSD CURRENT , Garrett Cooper X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Dec 2014 16:50:39 -0000 On Sat, Dec 06, 2014 at 04:01:26PM +0100, Dimitry Andric wrote: > [trimmed CC list to -current] > > On 06 Dec 2014, at 04:59, Garrett Cooper wrote: > > 2. Why isn?t this value determined once in Makefile.inc1 (per build phase), then passed down from there > > Because you are supposed to be able to build stuff in a subdirectory, > without invoking the full top-level Makefile infrastructure. The actual > infrastructure is in share/mk/bsd.*.mk, in fact. > > > > (I?ve already considered the scenario where someone explicitly sets CC in a non-toplevel Makefile, which is a problem, but an outlier rather than the norm)? AFAICT, it gets recomputed for every recursive make, which contributes to useless forking for something that honestly doesn?t change all that often/at all. > > This is indeed a pity, and if you know a better solution, let's hear it, > please. :-) > Why not also put this information into some environment variables with known ugly names, in top-level. Then, the lower-level calls of infrastructure first check the vars, and recalculate the compiler specific info if vars are absent. Use information from vars if present.