From owner-freebsd-i18n Fri Aug 16 0: 2:28 2002 Delivered-To: freebsd-i18n@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1AD0B37B400; Fri, 16 Aug 2002 00:02:22 -0700 (PDT) Received: from portege.clkao.org (61-216-79-243.HINET-IP.hinet.net [61.216.79.243]) by mx1.FreeBSD.org (Postfix) with ESMTP id 19B0543E72; Fri, 16 Aug 2002 00:02:21 -0700 (PDT) (envelope-from clkao@portege.clkao.org) Received: by portege.clkao.org (Postfix, from userid 1000) id D754448D; Fri, 16 Aug 2002 15:02:00 +0800 (CST) Date: Fri, 16 Aug 2002 15:02:00 +0800 From: Chia-liang Kao To: "Andrey A. Chernov" Cc: standards@FreeBSD.ORG, i18n@FreeBSD.ORG, keichii@FreeBSD.ORG, tjr@FreeBSD.ORG Subject: Re: wcwidth and mklocale Message-ID: <20020816070200.GA643@portege.clkao.org> References: <20020811181805.GA1809@portege.clkao.org> <20020812102835.GA1288@nagual.pp.ru> <20020813035009.GA1084@portege.clkao.org> <20020815154915.GA9607@portege.clkao.org> <20020815194941.GA9773@nagual.pp.ru> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0F1p//8PRICkK4MW" Content-Disposition: inline In-Reply-To: <20020815194941.GA9773@nagual.pp.ru> User-Agent: Mutt/1.5.1i Sender: owner-freebsd-i18n@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --0F1p//8PRICkK4MW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable right, should be iswprint. i should have used -Wall when testing. On Thu, Aug 15, 2002 at 11:49:41PM +0400, Andrey A. Chernov wrote: > On Thu, Aug 15, 2002 at 23:49:16 +0800, Chia-liang Kao wrote: > > +wcwidth(wc) > > + wchar_t wc; > > +{ > > + int width =3D (unsigned)__maskrune((wc), _CTYPE_SWM) >> _CTYPE_SWS; > > + return width ? width : isprint(wc); >=20 > Should it be iswprint() instead here? isprint() is not supposed to be=20 > called directly on wchar_t. Cheers, CLK --0F1p//8PRICkK4MW Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE9XKNok1XldlEkA5YRAuimAJ0Z616/3vJOHiGxIrUqButo74hWwwCZAcSY SssfbJnkdn7AkQ9kLOAFPI0= =2t83 -----END PGP SIGNATURE----- --0F1p//8PRICkK4MW-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-i18n" in the body of the message