Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 26 Sep 2005 21:21:10 +1000 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        Robert Watson <rwatson@freebsd.org>
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/kern subr_prf.c
Message-ID:  <20050926212051.J21547@delplex.bde.org>
In-Reply-To: <200509260802.j8Q82PFW064658@repoman.freebsd.org>
References:  <200509260802.j8Q82PFW064658@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 26 Sep 2005, Robert Watson wrote:

> rwatson     2005-09-26 08:02:24 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/kern             subr_prf.c
>  Log:
>  Acquire Giant in uprintf() and tprintf() rather than asserting it.  In
>  the vast majority of cases, these functions are called without mutexes
>  held, meaning that in all but two cases, there will be no ordering
>  issues with doing this, and it will eliminate the need for changes in
>  the caller.  In two cases, mutexes are held, so Giant must be acquired
>  before those mutexes such that uprintf() and tprintf() recurse Giant
>  rather than generating a lock order reversal.
>
>  Suggested by:   bde

Thansks.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050926212051.J21547>