From owner-freebsd-arm@FreeBSD.ORG  Thu Mar  5 04:28:27 2015
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 93FE7989
 for <freebsd-arm@freebsd.org>; Thu,  5 Mar 2015 04:28:27 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7284F79D
 for <freebsd-arm@freebsd.org>; Thu,  5 Mar 2015 04:28:27 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t254SRKi049628
 for <freebsd-arm@freebsd.org>; Thu, 5 Mar 2015 04:28:27 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t254SRq7049627;
 Thu, 5 Mar 2015 04:28:27 GMT (envelope-from root)
Date: Thu, 5 Mar 2015 04:28:27 +0000
To: freebsd-arm@freebsd.org
From: "emaste (Ed Maste)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Commented On] D2005: Start of arm64 toolchain support
 (sufficient for kernel-toolchain)
Message-ID: <35cd5164048de19a63fadbe5036b2f2c@localhost.localdomain>
X-Priority: 3
Thread-Topic: D2005: Start of arm64 toolchain support (sufficient for
 kernel-toolchain)
X-Herald-Rules: <23>
X-Phabricator-To: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-To: <PHID-USER-xp4awsksj2i7uxrs25tm>
X-Phabricator-Cc: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-Cc: <PHID-USER-pns6zgllnr6ze4h7ms3o>
X-Phabricator-Cc: <PHID-MLST-stsrni3uozki6w7zubvy>
In-Reply-To: <differential-rev-PHID-DREV-xkiyys7g7nptp5rxbteo-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-xkiyys7g7nptp5rxbteo-req@FreeBSD.org>
Thread-Index: MWIwYjI4MjVhOWQ4NTczNDM4ZTQ0MzM1OTZhIFT322s=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Mar 2015 04:28:27 -0000

emaste added a comment.



INLINE COMMENTS
  Makefile.inc1:325 We can change the test to `BINUTILS_BOOTSTRAP` in `__ALWAYS_NO` instead. It seems reasonable that those cases where we force it off ought to have the default.
  
  Something similar to
  ```
  # If we do not have a bootstrap binutils (because the in-tree one does not    
  # support the target architecture), provide a default cross-binutils prefix.  
  # This allows aarch64 builds, for example, to automatically use the
  # aarch64-binutils port or package.
  .if !empty(__ALWAYS_NO:MBINUTILS_BOOTSTRAP) && !defined(CROSS_BINUTILS_PREFIX) 
  CROSS_BINUTILS_PREFIX=/usr/local/${TARGET_ARCH}-freebsd/bin/
  .if !exists(${CROSS_BINUTILS_PREFIX})
  .error In-tree binutils does not support the ${TARGET_ARCH} architecture. Install the ${TARGET_ARCH}-binutils port or package or set CROSS_BINUTILS_PREFIX.
  .endif
  .endif
  ```

REVISION DETAIL
  https://reviews.freebsd.org/D2005

To: emaste, bdrewery
Cc: imp, andrew, freebsd-arm