Date: Thu, 12 Oct 2006 08:59:16 -0500 From: "Scot Hetzel" <swhetzel@gmail.com> To: "Jeremie Le Hen" <jeremie@le-hen.org> Cc: freebsd-ports@freebsd.org Subject: Re: multimedia/mplayer/Makefile information request Message-ID: <790a9fff0610120659y7090e8edmeed00d653458046a@mail.gmail.com> In-Reply-To: <20061012105240.GJ1594@obiwan.tataz.chchile.org> References: <20061012105240.GJ1594@obiwan.tataz.chchile.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/12/06, Jeremie Le Hen <jeremie@le-hen.org> wrote:
> Hi list,
>
> please Cc: me in your reply.
>
> This is not that important, but I wonder what's the point of this
> in multimedia/mplayer/Makefile:
>
> % .if !defined(WITHOUT_X11)
> % USE_XLIB= yes
> % CFLAGS+= -I${X11BASE}/include
> % CONFIGURE_ARGS+=--with-x11libdir=${X11BASE}/lib \
> % --with-x11incdir=${X11BASE}/include
> % .else
>
> If "--with-x11incdir=${X11BASE}/include" is here, what's the point
> of using "CFLAGS+= -I${X11BASE}/include" ? It appears to be
> superfluous.
>
It looks like it might be, try commenting that line out in the
Makefile and then build, install, and test the port. If it works,
then submit a PR to have that line removed.
Scot
--
DISCLAIMER:
No electrons were mamed while sending this message. Only slightly bruised.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?790a9fff0610120659y7090e8edmeed00d653458046a>