From owner-freebsd-ports@FreeBSD.ORG  Thu Oct 12 13:59:19 2006
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: freebsd-ports@freebsd.org
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 93CB116A494
	for <freebsd-ports@freebsd.org>; Thu, 12 Oct 2006 13:59:19 +0000 (UTC)
	(envelope-from swhetzel@gmail.com)
Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.175])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1246D43D45
	for <freebsd-ports@freebsd.org>; Thu, 12 Oct 2006 13:59:17 +0000 (GMT)
	(envelope-from swhetzel@gmail.com)
Received: by ug-out-1314.google.com with SMTP id m2so265937uge
	for <freebsd-ports@freebsd.org>; Thu, 12 Oct 2006 06:59:16 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com;
	h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=miXV9Pq1Lo4ncsfmvR4p3QoMQwSz7/AFEZy0pnetXIDkujqcjqGvlchbL/mOfqyYiG5c5O+cKS8ZnJ0lOWldWwJU3JeYWk5gCopONmWM2NhgtZ7h7O0f7uOS3hWVdokyO+nuz/iHia6rYTnENREpn/Ihx76FJjvoOyyD0lFex04=
Received: by 10.67.24.13 with SMTP id b13mr2774349ugj;
	Thu, 12 Oct 2006 06:59:16 -0700 (PDT)
Received: by 10.67.86.8 with HTTP; Thu, 12 Oct 2006 06:59:16 -0700 (PDT)
Message-ID: <790a9fff0610120659y7090e8edmeed00d653458046a@mail.gmail.com>
Date: Thu, 12 Oct 2006 08:59:16 -0500
From: "Scot Hetzel" <swhetzel@gmail.com>
To: "Jeremie Le Hen" <jeremie@le-hen.org>
In-Reply-To: <20061012105240.GJ1594@obiwan.tataz.chchile.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20061012105240.GJ1594@obiwan.tataz.chchile.org>
Cc: freebsd-ports@freebsd.org
Subject: Re: multimedia/mplayer/Makefile information request
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Oct 2006 13:59:19 -0000

On 10/12/06, Jeremie Le Hen <jeremie@le-hen.org> wrote:
> Hi list,
>
> please Cc: me in your reply.
>
> This is not that important, but I wonder what's the point of this
> in multimedia/mplayer/Makefile:
>
> % .if !defined(WITHOUT_X11)
> % USE_XLIB=       yes
> % CFLAGS+=        -I${X11BASE}/include
> % CONFIGURE_ARGS+=--with-x11libdir=${X11BASE}/lib \
> %                 --with-x11incdir=${X11BASE}/include
> % .else
>
> If "--with-x11incdir=${X11BASE}/include" is here, what's the point
> of using "CFLAGS+= -I${X11BASE}/include" ?  It appears to be
> superfluous.
>
It looks like it might be, try commenting that line out in the
Makefile and then build, install, and test the port.  If it works,
then submit a PR to have that line removed.

Scot
-- 
DISCLAIMER:
No electrons were mamed while sending this message. Only slightly bruised.