Date: Wed, 13 Nov 2013 16:20:09 -0600 From: Mark Felder <feld@FreeBSD.org> To: Chad Gross <avatar4d@gmail.com> Cc: freebsd-ports@freebsd.org Subject: Re: NfSen Port PATCH Message-ID: <88E1B73E-10D0-4949-A35C-52927187F84C@FreeBSD.org> In-Reply-To: <CAHP1p-UJ-ZE-RcLxmrg5fsMSfKuxPk6p4Sug3A4=z2aeibKYKw@mail.gmail.com> References: <CAHP1p-UJ-ZE-RcLxmrg5fsMSfKuxPk6p4Sug3A4=z2aeibKYKw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_AE7327F4-3B9A-41BD-884E-BF0EE5E366F3
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=windows-1252
On Nov 13, 2013, at 12:27, Chad Gross <avatar4d@gmail.com> wrote:
> I found an issue with the nfsen port Makefile. It is not properly
> configured to expand the %%PORTNAME%% variable used when generating =
the
> nfsen config file.
>=20
>=20
> For example, the config that is installed shows this:
>=20
> $VARDIR=3D"${BASEDIR}/var/%%PORTNAME%%";
>=20
>=20
> When it should be this:
>=20
> $VARDIR=3D"${BASEDIR}/var/nfsen";
>=20
> I have attached the patch, but also included it in-line below. I =
emailed
> the maintainer, but hadn't heard a response so figured I would send it =
here
> just in case.
>=20
>=20
> --- Makefile 2013-11-03 12:31:00.000000000 -0500
>=20
> +++ Makefile.new 2013-11-03 12:30:51.000000000 -0500
>=20
> @@ -37,6 +37,7 @@
>=20
> SUB_LIST+=3D "PORTVERSION=3D${PORTVERSION}"
>=20
> SUB_LIST+=3D "PREFIX=3D${PREFIX}"
>=20
> SUB_LIST+=3D "WWWDIR=3D${WWWDIR}"
>=20
> +SUB_LIST+=3D "PORTNAME=3D${PORTNAME}"
>=20
>=20
>=20
> NO_STAGE=3D yes
>=20
> post-patch:
>=20
>=20
> Thanks,
>=20
Thanks for catching this. I=92m not sure how I missed this when I =
rewrote the port=85 I definitely tested clean installs, but I must have =
provided my own configs
--Apple-Mail=_AE7327F4-3B9A-41BD-884E-BF0EE5E366F3
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=signature.asc
Content-Type: application/pgp-signature;
name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQEcBAEBCgAGBQJSg/saAAoJEJg7ZFAfE+JSX7gH/i0zxwWu/mKmuXXYOyBF2oWi
L0Db+iLulnqxO8VF5xGleMMlSmEw6YlwbI3N5CG5+NZ+ct9w1wr1+evU4+ljZVG0
KtgjPCDruEWtMCtDgL7H/9W5i7PKQ2pPvMqU1AfcJbTQfihNQv4jUzWVNEU2QeTI
6PuZTTSaOEnzK1EtZtC8asVhNAypkegESkEdgSoglBDuTfM7SS06gH1x+OgDJBiw
xOAhXjPhTn1MOrXLGasOSlZ1BzdDHoMQEnJFqr2fLWfnbGvfe93Xj7QgaoTNPmLU
ueXs0ub1icTFe9d29tgrdI7YwDhAp/hx484wmGzg53ijYkxNe57ztckfGFfhd5M=
=FihV
-----END PGP SIGNATURE-----
--Apple-Mail=_AE7327F4-3B9A-41BD-884E-BF0EE5E366F3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?88E1B73E-10D0-4949-A35C-52927187F84C>