Date: Sat, 28 Feb 2004 21:18:37 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Nate Lawson <nate@root.org> Cc: Dag-Erling Smorgrav <des@FreeBSD.org> Subject: Re: cvs commit: src/usr.bin/login Makefile Message-ID: <20040228210551.X5866@gamplex.bde.org> In-Reply-To: <20040227105019.O86020@root.org> References: <20040227175103.2B36916A4EA@hub.freebsd.org> <20040227105019.O86020@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 27 Feb 2004, Nate Lawson wrote:
> On Fri, 27 Feb 2004, Dag-Erling Smorgrav wrote:
> >...
> > Index: src/usr.bin/login/Makefile
> > diff -u src/usr.bin/login/Makefile:1.44 src/usr.bin/login/Makefile:1.45
> > --- src/usr.bin/login/Makefile:1.44 Fri Feb 27 00:39:16 2004
> > +++ src/usr.bin/login/Makefile Fri Feb 27 09:50:59 2004
> > @@ -7,6 +7,11 @@
> > DPADD= ${LIBUTIL} ${LIBPAM}
> > LDADD= -lutil ${MINUSLPAM}
> > MAN= login.1 login.access.5
> > +.ifdef NO_SETUID_LOGIN
> > +BINOWN= root
> > +BINMODE=4555
> > +INSTALLFLAGS=-fschg
> > +.endif
> > NEED_LIBNAMES= yes
> >
> > .include <bsd.prog.mk>
>
> I believe this should be ifndef for the proper behavior.
More precisely, it should be ".if !defined(...)". "ifndef" is a style
bug in Makefiles. It is only used in 4 makefiles in src. Note that
the normal style for this in Makfiles is exactly the opposite of the
normal style for this in C programs.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040228210551.X5866>