From owner-svn-ports-head@FreeBSD.ORG Sat Jan 10 18:46:26 2015 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B201D786; Sat, 10 Jan 2015 18:46:26 +0000 (UTC) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 84FD15E6; Sat, 10 Jan 2015 18:46:26 +0000 (UTC) Received: from [192.168.0.22] (unknown [130.255.19.191]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 00A6243BD4; Sat, 10 Jan 2015 12:46:18 -0600 (CST) Message-ID: <54B17372.8000205@marino.st> Date: Sat, 10 Jan 2015 19:46:10 +0100 From: John Marino Reply-To: marino@freebsd.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Antoine Brodin , John Marino Subject: Re: svn commit: r376718 - head/lang/fpc References: <201501101755.t0AHtrTf069687@svn.freebsd.org> <54B16EA4.2070106@marino.st> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Jan 2015 18:46:26 -0000 On 1/10/2015 19:37, Antoine Brodin wrote: > On Sat, Jan 10, 2015 at 6:25 PM, John Marino wrote: >> On 1/10/2015 18:55, Antoine Brodin wrote: >>> Author: antoine >>> Date: Sat Jan 10 17:55:52 2015 >>> New Revision: 376718 >>> URL: https://svnweb.freebsd.org/changeset/ports/376718 >>> QAT: https://qat.redports.org/buildarchive/r376718/ >>> >>> Log: >>> Revert part of r376655 that is breaks freebsd ports >>> >>> With hat: portmgr >>> >> >> I'm going to go danfe here and request some clarification. This commit >> message does not indicate what exactly broke. Did fpmkunit not build? >> Is there a log? Why did portmgr have to step in versus asking the >> maintainer to look into it? >> > > Yes it broke fpmkunit, did you test on freebsd? > Your commit was supposed to be a nop for freebsd but it wasn't so I > reverted, supporting dragonfly is nice but breaking freebsd is not. Yes, I *only* used FreeBSD for testing. I built some extensions, not all 100 of them. It built everything I tested. >From your answer, I can't tell if fpmkunit built and didn't work, or just didn't build. I still think the maintainer / committer should be asked to look at it rather than instantly reverting. This wasn't a broken index or something like that. I mean, a few hours notice before reverting would have been ok, no? John