From owner-svn-ports-head@FreeBSD.ORG Wed Sep 3 18:13:10 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3A49BAC2; Wed, 3 Sep 2014 18:13:10 +0000 (UTC) Received: from mail-yh0-x233.google.com (mail-yh0-x233.google.com [IPv6:2607:f8b0:4002:c01::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C39621EF0; Wed, 3 Sep 2014 18:13:09 +0000 (UTC) Received: by mail-yh0-f51.google.com with SMTP id v1so5506907yhn.24 for ; Wed, 03 Sep 2014 11:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=updiI1pQng/PJiSoo2GkXU3XP/+eVMNMNkppYSLixQ8=; b=v57FsmfBbvd61rsHnIY3q7g759x2ojUSeWdTJ/k99wGrO8vEXCRdxHFOb6m4ANMBUk isAmSgNY1zOnHIipvui3nNWaQNT58WANedGOd1A0OJYTgkP2FcssDFSg8MzdNucwJV5J 7ESz0Kx1VLWjk6Zzde5vi7q2JVT0OQJB+obWaOPqRVqn0r/FB02rhobRickmJBXZeMaR fO+mfY/XB66yv3XUyv+H8JcbhWntnmTwY2QOBUiE0KpxMBNbpn/+CakIaXWJ1bC5okT7 PRgH+ofXK2kD4OGu47slX7UAtx0UPScm0+XDErK4+E8+QzWA3+Sz8yPux+IZnVTBo7xj 9hxg== MIME-Version: 1.0 X-Received: by 10.236.25.105 with SMTP id y69mr63316524yhy.33.1409767989008; Wed, 03 Sep 2014 11:13:09 -0700 (PDT) Sender: antoine.brodin.freebsd@gmail.com Received: by 10.170.164.197 with HTTP; Wed, 3 Sep 2014 11:13:08 -0700 (PDT) In-Reply-To: <20140903154317.GA42917@FreeBSD.org> References: <201409031525.s83FPHLO090538@svn.freebsd.org> <20140903152826.GA38672@FreeBSD.org> <20140903154317.GA42917@FreeBSD.org> Date: Wed, 3 Sep 2014 20:13:08 +0200 X-Google-Sender-Auth: e7C8VrBj5i--UPlIPcWm270LsQQ Message-ID: Subject: Re: svn commit: r367212 - in head: astro/planets devel/aifad ftp/ocaml-ocurl From: Antoine Brodin To: Alexey Dokuchaev Content-Type: text/plain; charset=UTF-8 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Sep 2014 18:13:10 -0000 On Wed, Sep 3, 2014 at 5:43 PM, Alexey Dokuchaev wrote: > On Wed, Sep 03, 2014 at 05:29:39PM +0200, Antoine Brodin wrote: >> On Wed, Sep 3, 2014 at 5:28 PM, Alexey Dokuchaev wrote: >> > Hey Antoine, can you explain what's going on here? Lots of ports are using >> > PLIST_FILES/PORTDOCS to avoid spamming the tree with little pkg-plist files, >> > and now you're essentially reverting it back. >> >> It fails to package because bsd.ocaml.mk is stupid, i just fix. > > OK; I actually have an idea to convert bsd.ocaml.mk to Uses/ocaml.mk. That > said, I once again want to remind (all of us) of the importance of providing > enough information in the commit logs. "Fix build" does not really explain > anything and only rises questions like mine. > > Please spend 30 seconds more to shut us up. :-) I'm looking forward to exp-run your USES=ocaml patch. Right now, the plist handling of ocaml ports is quite hazardous (non existing dirs added to plist, ports not setting OCAML_PKGDIRS when they should..) Cheers, Antoine