From owner-freebsd-current@FreeBSD.ORG Sat Sep 4 23:57:00 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6F26E16A507 for ; Sat, 4 Sep 2004 23:56:58 +0000 (GMT) Received: from mail3.speakeasy.net (mail3.speakeasy.net [216.254.0.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id E761043D2D for ; Sat, 4 Sep 2004 23:56:57 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: (qmail 3285 invoked from network); 4 Sep 2004 23:56:57 -0000 Received: from gate.funkthat.com (HELO hydrogen.funkthat.com) ([69.17.45.168]) (envelope-sender ) by mail3.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 4 Sep 2004 23:56:57 -0000 Received: from hydrogen.funkthat.com (cncvkb@localhost.funkthat.com [127.0.0.1])i84NuuuU048876; Sat, 4 Sep 2004 16:56:57 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id i84Nuti5048875; Sat, 4 Sep 2004 16:56:55 -0700 (PDT) Date: Sat, 4 Sep 2004 16:56:55 -0700 From: John-Mark Gurney To: Daniel Eriksson Message-ID: <20040904235655.GO29902@funkthat.com> Mail-Followup-To: Daniel Eriksson , freebsd-current@freebsd.org References: <20040825175250.GO29902@funkthat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: freebsd-current@freebsd.org Subject: Re: if_re locking patch... X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Sep 2004 23:57:01 -0000 Daniel Eriksson wrote this message on Sat, Sep 04, 2004 at 12:33 +0200: > John-Mark Gurney wrote: > > > To expand upon the patch posted previously, I have cribbed bms's rl > > locking, and ported it to re. This makes the interrupt MPSAFE along > > with the rest of the driver. No more GIANT LOCKED messages for re. :) > > I saw that this was committed to HEAD yesterday. I have a machine with a > 8169-based NIC that is doing ~300GB on a daily basis that I'd love to try to > run with debug.mpsafenet=1. Do you think the patch that went into HEAD has > been tested enough that it is safe to try it? > > It's a UP machine using POLLING mode (HZ=2000), if that makes any > difference. Well, as demonstrated by ru's commit (thanks ru!).. I had not tested DEVICE_POLLING... But this afternoon I did some testing, and did not have any troubles... The only problems w/ netperf was that the *RR* tests were a bit slow, but this is to be expected due to DEVICE_POLLING.. But as I mentioned, the re driver was originally based on the rl, so I doubt there'll be much trouble since rl's locking has been in the tree for quite a while longer... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."